Merged
Conversation
billti
approved these changes
Jun 1, 2017
Member
billti
left a comment
billti
left a comment
There was a problem hiding this comment.
So is this changing from WinForm to Xaml, hence the resource file changes? Be sure to test and make sure we don't hit those exceptions we got last time!
Contributor
Author
|
No this is still winforms. I pulled all the localization from the page specific resx files, and added that to the general resx file. This makes it much easier to make changes in the future. (And will make the move to the new localization file much easier). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of issues around accessibility, and smaller UI fixes.