Change the command to raise when adding new project from existing code

[zhengbli]

This PR fixes #133.

Previously the raised command when adding new project from existing code is VSConstants.VSStd97CmdID.OpenProject, which actually corresponds to the Open Project menu item, that will always create a new solution. Changing it to VSConstants.VSStd97CmdID.AddExistingProject fixed the problem.

[paulvanbrenk]

👍

[billti]

Thanks for figuring this out!

Now you are calling AddProject instead of OpenProject, I can see how this fixes the issue referenced. Did you also check that running the "Import from existing code" scenario with no existing project/sln open still continues to work also?

[zhengbli]

Right, after some tests it didn't work for the no-existing project/sln scenario. I need to fix that.

[zhengbli]

@billti Added code to detect the availability of the "Add Existing Project", now it works as expected in both cases.

[mousetraps]

Does this work in the instance where a project is open (so the AddExistingProject command is available), but someone is nonetheless creating a new project?

Perhaps a better solution is to intercept the command in the NodejsPackage.Initialize() step by handling BeforeExecute and AfterExecute events (set a boolean flag that we check in ImportWizardCommand).
E.g. http://stackoverflow.com/questions/15406523/visual-studio-extensibility-intercepting-file-paste-event

[mousetraps]

Alternatively, just pass in the cmdIdToRaise rather than effectively checking it twice.

Then, you can can simplify all this to:

NodejsPackage.Instance.DTE.Commands.Raise(
VSConstants.GUID_VSStandardCommandSet97.ToString("B"), cmdIdToRaise, ref pathRef, ref outRef);

[mousetraps]

Overall implementation looks good now - left several minor comments and lgtm after that.

[zhengbli]

@mousetraps can you take a look at my updates? Thanks!

[mousetraps]

👍