#246, #362 - Debugger listening but program not starting, flakey debugger behavior#448
Merged
mousetraps merged 1 commit intomicrosoft:masterfrom Sep 14, 2015
Merged
Conversation
The issue in this case stems from sending an AD7LodCompleteRunningEvent when we should be sending an AD7LoadCompleteEvent. In particular, _processLoadedRunning is set to true here even though execution ends up being paused later. The fix is to only load the "running" value after modules are loaded, rather than beforehand. are loaded, so load the property then rather than beforehand.
mousetraps
added a commit
that referenced
this pull request
Sep 14, 2015
#246, #362 - Debugger listening but program not starting, flakey debugger behavior The issue in this case stems from sending an AD7LodCompleteRunningEvent when we should be sending an AD7LoadCompleteEvent. In particular, _processLoadedRunning is set to true here even though execution ends up being paused later. The fix is to only load the "running" value after modules are loaded, rather than beforehand. are loaded, so load the property then rather than beforehand. Fix #362, fix #246
Contributor
Author
There was a problem hiding this comment.
Makes it easier to read between the lines. I'll remove it 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue in this case stems from sending an AD7LodCompleteRunningEvent
when we should be sending an AD7LoadCompleteEvent. In particular,
_processLoadedRunning is set to true here even though execution ends up
being paused later.
The fix is to only load the "running" value after modules are loaded,
rather than beforehand.
are loaded, so load the property then rather than beforehand.
Fix #362, fix #246