Skip to content

iterated according to CR comments #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mousetraps merged 1 commit into from
Sep 15, 2015
Merged

iterated according to CR comments #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Nodejs/Product/Nodejs/Debugger/DebugEngine/AD7Engine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,7 +1149,6 @@ private void OnModuleLoaded(object sender, ModuleLoadedEventArgs e) {
if (_loadComplete) {
SendModuleLoad(adModule);
}

}
}

Expand Down
5 changes: 3 additions & 2 deletions Nodejs/Product/Nodejs/Debugger/NodeDebugger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,9 @@ public async Task BreakAllAsync() {
}

internal bool IsRunning() {
var backtraceCommand = new BacktraceCommand(CommandId, _resultFactory, 0, 1);
if (TrySendRequestAsync(backtraceCommand).GetAwaiter().GetResult()) {
var backtraceCommand = new BacktraceCommand(CommandId, _resultFactory, fromFrame: 0, toFrame: 1);
var tokenSource = new CancellationTokenSource(_timeout);
if (TrySendRequestAsync(backtraceCommand, tokenSource.Token).GetAwaiter().GetResult()) {
return backtraceCommand.Running;
}
return false;
Expand Down