#508 Unhandled System.ArgumentException and#524
Merged
mousetraps merged 2 commits intomicrosoft:masterfrom Oct 13, 2015
Merged
Conversation
System.IndexOutOfRangeException during LoadCachedAnalysis - We were simultaneously mutating the AnalysisLog from two threads. This caused various Deque properties like _data, _tail, etc. to get out of sync with one another. The fix is to lock LogItems whenever adding new events to the log.
Member
|
👍 |
Contributor
Author
There was a problem hiding this comment.
I'll find a way to do this without locking, so it doesn't reduce performance
…it is called on the analysis thread.
Contributor
Author
|
Removed the locking behavior and added some comments. Instead we now just create RequireAnalysisUnits on the analysis thread. |
mousetraps
added a commit
that referenced
this pull request
Oct 13, 2015
#508 Unhandled System.ArgumentException and
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.IndexOutOfRangeException during LoadCachedAnalysis
caused various Deque properties like _data, _tail, etc. to get out of
sync with one another. The fix is to lock LogItems whenever adding new
events to the log.
fix #508