Skip to content

#548 Debugger retry logic continues attempting to connect even though… #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mousetraps merged 1 commit into from
Oct 20, 2015
Merged

#548 Debugger retry logic continues attempting to connect even though… #554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Nodejs/Product/Nodejs/Debugger/Communication/DebuggerConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ sealed class DebuggerConnection : IDebuggerConnection {
private readonly INetworkClientFactory _networkClientFactory;
private INetworkClient _networkClient;
private readonly object _networkClientLock = new object();
private volatile Version _nodeVersion;
private volatile Version _nodeVersion;
private bool _isClosed = false;

public DebuggerConnection(INetworkClientFactory networkClientFactory) {
Utilities.ArgumentNotNull("networkClientFactory", networkClientFactory);
Expand All @@ -51,8 +52,10 @@ public void Dispose() {
/// <summary>
/// Close connection.
/// </summary>
public void Close() {
lock (_networkClientLock) {
public void Close() {
_isClosed = true;

lock (_networkClientLock) {
if (_networkClient != null) {
_networkClient.Dispose();
_networkClient = null;
Expand Down Expand Up @@ -119,7 +122,7 @@ public void Connect(Uri uri) {
lock (_networkClientLock) {
int connection_attempts = 0;
const int MAX_ATTEMPTS = 5;
while (true) {
while (!_isClosed) {
connection_attempts++;
try {
// TODO: This currently results in a call to the synchronous TcpClient
Expand Down