#552 Gruntfile.js failed to load#593
Merged
mousetraps merged 1 commit intomicrosoft:masterfrom Nov 17, 2015
Merged
Conversation
Previously we were relying on GetEditLabel() to produce the non-display-name. This was problematic because sometimes GetEditLabel returns null or produces a NotImplementedException when a node cannot be renamed. Instead, expose GetItemName, which will always return the underlying file or directory name based on the Url.
Contributor
Author
|
Note that as described in #552... I never managed to actually reproduce the underlying issue, so we can't verify the fix. |
mousetraps
added a commit
that referenced
this pull request
Nov 17, 2015
#552 Gruntfile.js failed to load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were relying on GetEditLabel() to produce the
non-display-name. This was problematic because sometimes GetEditLabel
returns null or produces a NotImplementedException when a node cannot be
renamed. Instead, expose GetItemName, which will always return the
underlying file or directory name based on the Url.
fix #552