Skip to content

Temp disable all tests that are failing in AppVeyor#717

Merged
mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz:disable-failing-appveyor-tests
Mar 2, 2016
Merged

Temp disable all tests that are failing in AppVeyor#717
mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz:disable-failing-appveyor-tests

Conversation

@mjbvz
Copy link
Copy Markdown
Contributor

@mjbvz mjbvz commented Feb 29, 2016

We need to get CI back into a good state so we can have some confidence when merging in pull requests. This change just disables all tests that are failing in appveyor. Related to #689

The major source of problems is the REPL tests, which seem to be failing nondeterministicly. I think there is because of SocketLock and threading. I just disabled them all for now but will revise this later.

We need to get CI back into a good state so we can have some confidence when merging in pull requests. This change just disables all tests that are failing in appveyor.

The major source of problems is the REPL tests, which seem to be failing nondeterministicly. I think there is because of their SocketLock implementation, I just disabled them all for now but will revist making a fix later.
@msftclas
Copy link
Copy Markdown

Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Matt Bierner). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@mjbvz mjbvz changed the title Temp disable all unit tests that are failing in AppVeyor Temp disable all tests that are failing in AppVeyor Feb 29, 2016
@mjbvz
Copy link
Copy Markdown
Contributor Author

mjbvz commented Feb 29, 2016

I've opened #718 with some ideas of how to deal with the skipped unit tests.

Comment thread Nodejs/Tests/Core/ReplWindowTests.cs Outdated
}
}

[Ignore]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, this is already being ignored.

@mousetraps
Copy link
Copy Markdown
Contributor

For the tests that are only failing in AppVeyor, and not locally with the same configuration, let's instead use the vstest TestCaseFilter option to ignore them because we might be able to fix some of these without modifying the code itself.

@mousetraps
Copy link
Copy Markdown
Contributor

Also, have you changed anything about the AppVeyor run lately? It looks like it's failing after 2 min, and it should very much pass for this PR 😃

@mjbvz
Copy link
Copy Markdown
Contributor Author

mjbvz commented Mar 1, 2016

Ok, that sounds like a good plan. Will send out the updated review shortly.

I have not intentionally changed anything in AppVeyor but it did seem to start failing yesterday. Let's see what happens when I update this PR.

@mjbvz
Copy link
Copy Markdown
Contributor Author

mjbvz commented Mar 1, 2016

I've marked the unreliable/failing appveyor only tests with the category AppVeyorIgnore. I also ignored a few other tests that really were failing locally.

mjbvz added a commit that referenced this pull request Mar 2, 2016
Temp disable all tests that are failing in AppVeyor

Will update appveyor scripts to ignore these as well.
@mjbvz mjbvz merged commit c150d22 into microsoft:master Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants