Temp disable all tests that are failing in AppVeyor#717
Temp disable all tests that are failing in AppVeyor#717mjbvz merged 3 commits intomicrosoft:masterfrom
Conversation
We need to get CI back into a good state so we can have some confidence when merging in pull requests. This change just disables all tests that are failing in appveyor. The major source of problems is the REPL tests, which seem to be failing nondeterministicly. I think there is because of their SocketLock implementation, I just disabled them all for now but will revist making a fix later.
|
Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
I've opened #718 with some ideas of how to deal with the skipped unit tests. |
| } | ||
| } | ||
|
|
||
| [Ignore] |
There was a problem hiding this comment.
Hrm, this is already being ignored.
|
For the tests that are only failing in AppVeyor, and not locally with the same configuration, let's instead use the vstest TestCaseFilter option to ignore them because we might be able to fix some of these without modifying the code itself. |
|
Also, have you changed anything about the AppVeyor run lately? It looks like it's failing after 2 min, and it should very much pass for this PR 😃 |
|
Ok, that sounds like a good plan. Will send out the updated review shortly. I have not intentionally changed anything in AppVeyor but it did seem to start failing yesterday. Let's see what happens when I update this PR. |
|
I've marked the unreliable/failing appveyor only tests with the category |
Temp disable all tests that are failing in AppVeyor Will update appveyor scripts to ignore these as well.
We need to get CI back into a good state so we can have some confidence when merging in pull requests. This change just disables all tests that are failing in appveyor. Related to #689
The major source of problems is the REPL tests, which seem to be failing nondeterministicly. I think there is because of
SocketLockand threading. I just disabled them all for now but will revise this later.