Disable Debug Assertion for Parsing NPM Person objects

[mjbvz]

Defect
While debugging, Npm Person ends up throwing thousands and thousands of exceptions because the Json data it is receiving from NPM is invalid according to its current check. It expects an object, but a person in a package.json may also be a string: https://docs.npmjs.com/files/package.json#people-fields-author-contributors

Fix

• Moved the parsing logic for Person to a factory named CreateFromJsonSource. This should make it clear to callers what this function does.
• For parsing, also accept just regular json strings as input. The new factory does not parse this field currently but uses it as the name field for now. Parsing may be added later.
• Added some unit tests to pin the existing behavior and test the new string behavior.

A whitespace only change to InteractiveWindow.cs is included in this PR. Git automatically created this change and I cannot undo it without manually editing the .gitattributes file. I think we just need to commit this file again so that git is no longer confused about the line endings in this file.

[msftclas]

Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Matt Bierner). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

[mjbvz]

Weird... I was wondering about those names but thought it was intentional. Reshaper's extract messed something up here. Will undo this.

[mousetraps]

You should be able to remove this change now that #709 has been merged

[mjbvz]

Ok, I removed the string person regex stuff for now, addressed the other comments, and have synced with master to get rid of any line ending changes.

[mjbvz]

@mousetraps can you please take another quick look at this review. This currently makes debugging a pain if you ever accidentally trigger the npm download, plus the assertion is not even correct to being with.

[mousetraps]

test categories still need to be updated but 👍 after that!