Skip to content

Added links to running our tests to CONTRIBUTING.md #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 2 commits into from
Mar 2, 2016
Merged

Added links to running our tests to CONTRIBUTING.md #725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d00075a
Added links to running our tests
mjbvz Mar 2, 2016
4ede9fe
Fix link
mjbvz Mar 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ In order to help us improve code quality and make NTVS better in general, here a
- If you're adding a new feature, explain the feature and its use cases.
- Provide a high level explanation of your changes. This will help reviewers understand implementation choices and will speed up the review process.
- Try to keep pull requests small and focused.
- Make sure that existing tests continue to pass.
- [Run our tests][running-tests] to ensure existing tests continue to pass.
- All new code must include tests.
- For a bug fix, consider adding a test that would fail before your change, but passes now.
- Feel free to ask for advice if you are unsure how what to test or how to integrate into our test infrastructure.
- Feel free to ask for advice if you are unsure how what to test or how to integrate into [our test infrastructure][running-tests].
- There is no formal code style-guide, but please try to match the style of any file you are editing.

All pull requests are reviewed by one of the project maintainers before being merged in. If you are unsure of anything, feel free to ask a question. We're always happy to help.
All pull requests are reviewed by one of the project maintainers before being merged in. If you are unsure of anything, feel free to ask. We're always happy to help.

### Licensing and Legal
Node.js Tools for Visual Studio is a member of [Microsoft](http://microsoft.github.io/) and operates under the [Apache 2.0 license](https://github.com/Microsoft/nodejstools/blob/master/LICENSE).
Expand All @@ -36,4 +36,5 @@ Node.js Tools for Visual Studio is a member of [Microsoft](http://microsoft.gith
All contributions will be made under the Apache 2.0 license. Please don’t submit anything with any other licensing statements. If you want to make a contribution that includes code that under a different license, please let us know so we can figure out what to do. Also, make sure you have the right to make your contribution, including clearance from your employer if applicable.


[cla]: https://cla.microsoft.com/
[cla]: https://cla.microsoft.com/
[running-tests]: https://github.com/Microsoft/nodejstools/wiki/Running-Our-Tests