Merged
Conversation
For microsoft#718, ignored tests tend to just get more broken over time so we should make ignoring explicit instead of automatic. This removes all [Ignore] tags and instead marks previously ignored tests with [TestCategory('Ignore')]. Will update appveyor to ignore these as well. closes microsoft#718
|
Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Contributor
|
Sweet! 👍 |
Contributor
|
Also, feel free to go ahead and touch common as well if they were being ignored. We'll clean that up when we merge back in. |
mjbvz
added a commit
that referenced
this pull request
Mar 7, 2016
Merging in this work. AppVeyor isn't failing any more than it was before ( although #723 should fix that ). Can change the common tests too if those start causing problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #718, ignored tests tend to just get more broken over time so we should make ignoring explicit instead of automatic. This removes all
[Ignore]tags and instead marks previously ignored tests with[TestCategory('Ignore')]. I've updated appveyor to ignore these as well.This only touches tests in NodeJs. Not Common.
closes #718