Reduce memory usage by not holding onto Json.net objects

Nodejs/Product/Npm/IPackageJson.cs

@@ -20,13 +20,10 @@ namespace Microsoft.NodejsTools.Npm {
     public interface IPackageJson {
         string Name { get; }
         SemverVersion Version { get; }
-        IScripts Scripts { get; }
         IPerson Author { get; }
         string Description { get; }
         IKeywords Keywords { get; }
         IHomepages Homepages { get; }
-        IBugs Bugs { get; }
-        ILicenses Licenses { get; }
         IFiles Files { get; }
         IMan Man { get; }
         IDependencies Dependencies { get; }

Nodejs/Product/Npm/Npm.csproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <Choose>
     <When Condition=" '$(VisualStudioVersion)'=='15.0'  Or '$(TargetVisualStudioVersion)'=='VS150' ">
@@ -114,7 +114,6 @@
     <Compile Include="DependencyUrlType.cs" />
     <Compile Include="DirectoryPackageJsonSource.cs" />
     <Compile Include="FilePackageJsonSource.cs" />
-    <Compile Include="IBugs.cs" />
     <Compile Include="IBundledDependencies.cs" />
     <Compile Include="IDependencies.cs" />
     <Compile Include="IDependency.cs" />
@@ -137,8 +136,6 @@
     <Compile Include="IPerson.cs" />
     <Compile Include="IPkgStringArray.cs" />
     <Compile Include="IRootPackage.cs" />
-    <Compile Include="IScript.cs" />
-    <Compile Include="IScripts.cs" />
     <Compile Include="..\Nodejs\Nodejs.cs">
       <Link>Nodejs.cs</Link>
     </Compile>
@@ -173,15 +170,12 @@
     <Compile Include="SemverVersion.cs" />
     <Compile Include="SemverVersionFormatException.cs" />
     <Compile Include="SPI\AbstractNodeModules.cs" />
-    <Compile Include="SPI\Bugs.cs" />
     <Compile Include="SPI\BundledDependencies.cs" />
     <Compile Include="SPI\Dependencies.cs" />
     <Compile Include="SPI\Dependency.cs" />
     <Compile Include="SPI\DependencyUrl.cs" />
     <Compile Include="SPI\GlobalPackages.cs" />
     <Compile Include="SPI\Keywords.cs" />
-    <Compile Include="SPI\License.cs" />
-    <Compile Include="SPI\Licenses.cs" />
     <Compile Include="SPI\Man.cs" />
     <Compile Include="SPI\NodeModules.cs" />
     <Compile Include="SPI\NodeModulesProxy.cs" />
@@ -200,8 +194,6 @@
     <Compile Include="SPI\PkgStringArray.cs" />
     <Compile Include="SPI\PkgFiles.cs" />
     <Compile Include="SPI\RootPackage.cs" />
-    <Compile Include="SPI\Script.cs" />
-    <Compile Include="SPI\Scripts.cs" />
     <Compile Include="SQLite\CatalogTables.cs" />
     <Compile Include="SQLite\SQLite.cs" />
     <Compile Include="SQLite\SQLiteAsync.cs" />

Nodejs/Product/Npm/SPI/Dependencies.cs

@@ -21,31 +21,24 @@
 
 namespace Microsoft.NodejsTools.Npm.SPI {
     internal class Dependencies : IDependencies {
-        private JObject _package;
-        private string[] _dependencyPropertyNames;
+        private IList<Dependency> _dependencyProperties;
 
         public Dependencies(JObject package, params string[] dependencyPropertyNames) {
-            _package = package;
-            _dependencyPropertyNames = dependencyPropertyNames;
-        }
-
-        private IEnumerable<JObject> GetDependenciesProperties() {
-            foreach (var propertyName in _dependencyPropertyNames) {
-                var property = _package[propertyName] as JObject;
-                if (null != property) {
-                    yield return property;
+            _dependencyProperties = new List<Dependency>();
+            foreach (var propertyName in dependencyPropertyNames) {
+                var dependencies = package[propertyName] as JObject;
+                if (dependencies != null) {
+                    foreach (var property in dependencies.Properties()) {
+                        if (property.Value.Type == JTokenType.String) {
+                            _dependencyProperties.Add(new Dependency(property.Name, property.Value.Value<string>()));
+                        }
+                    }
                 }
             }
         }
 
         public IEnumerator<IDependency> GetEnumerator() {
-            var dependencyProps = GetDependenciesProperties();
-            foreach (var dependencies in dependencyProps) {
-                var properties = null == dependencies ? new List<JProperty>() : dependencies.Properties();
-                foreach (var property in properties) {
-                    yield return new Dependency(property.Name, property.Value.Value<string>());
-                }
-            }
+            return _dependencyProperties.GetEnumerator();
         }
 
         IEnumerator IEnumerable.GetEnumerator() {
@@ -58,10 +51,9 @@ public int Count {
 
         public IDependency this[string name] {
             get {
-                foreach (var dependencies in GetDependenciesProperties()) {
-                    var property = dependencies[name];
-                    if (null != property) {
-                        return new Dependency(name, property.Value<string>());
+                foreach (var dependeny in _dependencyProperties) {
+                    if (dependeny.Name == name) {
+                        return dependeny;
                     }
                 }
                 return null;