-
Notifications
You must be signed in to change notification settings - Fork 354
Synchronize Node.js <-> TS settings #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
Nodejs/Product/Nodejs/Options/NodejsFormattingDialogPage.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| //*********************************************************// | ||
| // Copyright (c) Microsoft. All rights reserved. | ||
| // | ||
| // Apache 2.0 License | ||
| // | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| // implied. See the License for the specific language governing | ||
| // permissions and limitations under the License. | ||
| // | ||
| //*********************************************************// | ||
|
|
||
| using System; | ||
| using System.Runtime.InteropServices; | ||
| using Microsoft.VisualStudio.Settings; | ||
| using Microsoft.VisualStudio.Shell.Interop; | ||
|
|
||
| namespace Microsoft.NodejsTools.Options { | ||
| public class NodejsFormattingDialogPage : NodejsDialogPage { | ||
| private readonly ISettingsManager _settingsManager; | ||
| private const string TypeScriptBaseName = "TextEditor.TypeScript.Specific."; | ||
|
|
||
| public NodejsFormattingDialogPage(string category) : base(category) { | ||
| uint handle; | ||
| string registryRoot; | ||
| var registry = NodejsPackage.Instance.GetService(typeof(SLocalRegistry)) as ILocalRegistry4; | ||
| var regKey = registry.GetLocalRegistryRootEx((uint)__VsLocalRegistryType.RegType_UserSettings, out handle, out registryRoot); | ||
| _settingsManager = (ISettingsManager)NodejsPackage.Instance.GetService(typeof(SVsSettingsPersistenceManager)); | ||
| } | ||
|
|
||
| internal override void SaveBool(string name, bool value) { | ||
| var keyName = GetKeyName(name); | ||
| var registryValue = value ? 1 : 0; | ||
| _settingsManager.SetValueAsync(keyName, registryValue, isMachineLocal: false); | ||
| } | ||
|
|
||
| internal override bool? LoadBool(string name) { | ||
| var value = _settingsManager.GetValueOrDefault<int?>(GetKeyName(name)); | ||
| if (value == null) { | ||
| return null; | ||
| } else { | ||
| return value != 0; | ||
| } | ||
| } | ||
|
|
||
| private static string GetKeyName(string name) { | ||
| if (name.EndsWith("_TEMP")) { | ||
| name = name.Remove(name.Length - 5); | ||
| } | ||
| return TypeScriptBaseName + name; | ||
| } | ||
|
|
||
| [Guid("9B164E40-C3A2-4363-9BC5-EB4039DEF653")] | ||
| private class SVsSettingsPersistenceManager { } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can
textMgrever be null?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't null check anywhere, and I wouldn't expect it to ever be null (except maybe inside of some of the mock test cases?)