Skip to content

Fix svm runtime (replaces #91, #33) - #101

Merged
xadupre merged 41 commits into
masterfrom
xadupre/svm
May 14, 2019
Merged

Fix svm runtime (replaces #91, #33)#101
xadupre merged 41 commits into
masterfrom
xadupre/svm

Conversation

@xadupre

@xadupre xadupre commented Dec 5, 2018

Copy link
Copy Markdown
Member

No description provided.

@xadupre
xadupre requested a review from a team as a code owner December 5, 2018 11:28
sdpython added 12 commits December 6, 2018 10:57
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
9c90503 
…o xadupre/svm
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
294e40b 
…o xadupre/svm
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
241a6b1 
…o xadupre/svm
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
8750494 
…o xadupre/svm
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
ab0a592 
…o xadupre/svm
@sdpython
merge
58e4bfe
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
442ad63 
…o xadupre/svm
@sdpython
update onnx
d0b7cf4
@sdpython
Create gemmlowp
bad8a90
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
260d446 
…o xadupre/svm
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
881c3b4 
…o xadupre/svm
@sdpython
Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…
da7d4b2 
…o xadupre/svm
@xadupre
xadupre requested a review from weixingzhang February 6, 2019 23:15
linkerzhang
linkerzhang reviewed Feb 14, 2019
View reviewed changes
Comment thread onnxruntime/test/providers/cpu/ml/svmclassifier_test.cc Outdated
linkerzhang
linkerzhang reviewed Mar 6, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/ml_common.h Outdated
wschin
wschin reviewed Mar 6, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/svmclassifier.cc Outdated
wschin
wschin reviewed Mar 6, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/svmclassifier.cc Outdated
wschin
wschin reviewed Mar 8, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/svmclassifier.cc Outdated
wschin
wschin reviewed Mar 8, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/svmclassifier.cc Outdated
wschin
wschin reviewed Mar 8, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/svmclassifier.h Outdated
wschin
wschin reviewed Mar 8, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/svmclassifier.h Outdated
wschin
wschin reviewed Mar 8, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/svmclassifier.h Outdated
jignparm
jignparm reviewed Mar 28, 2019
View reviewed changes
Comment thread onnxruntime/core/providers/cpu/ml/ml_common.h
@vinitra-zz

vinitra-zz commented Apr 2, 2019

Copy link
Copy Markdown

quick ping to revive PR -- this fix is needed to recover libSVM conversion in onnxmltools.

@vinitra-zz vinitra-zz mentioned this pull request Apr 2, 2019
Merged
wschin
wschin previously approved these changes Apr 2, 2019
View reviewed changes

@wschin wschin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@vinitra-zz vinitra-zz mentioned this pull request Apr 12, 2019
Merged
@vinitra-zz
vinitra-zz requested a review from wschin May 1, 2019 21:44
@vinitra-zz

vinitra-zz commented May 9, 2019

Copy link
Copy Markdown

@wschin, could you review again? Some libsvm converter capabilities need the changes made in this PR.

@vinitra-zz
vinitra-zz requested review from vinitra-zz and removed request for vinitra-zz May 10, 2019 20:21
@xadupre
xadupre merged commit d32d2fb into master May 14, 2019
@yuslepukhin
yuslepukhin deleted the xadupre/svm branch August 6, 2019 17:03
TedThemistokleous pushed a commit to TedThemistokleous/onnxruntime that referenced this pull request Jun 2, 2025
@jagadish-amd
Merge pull request microsoft#101 from jagadish-amd/rocm6.4_internal_t…
0b9b28b 
…esting_cmake_hip

ROCm: add python arg to pass DCMAKE_HIP_ARCHITECTURES
yuslepukhin pushed a commit that referenced this pull request Mar 17, 2026
@leqiao-1
Merge pull request #101 from microsoft/leqiao/fp_32
95c1194 
add fp32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weixingzhang weixingzhang Awaiting requested review from weixingzhang
@wschin wschin Awaiting requested review from wschin
4 more reviewers
@linkerzhang linkerzhang linkerzhang left review comments
@yuslepukhin yuslepukhin yuslepukhin left review comments
@jignparm jignparm jignparm left review comments
@vinitra-zz vinitra-zz vinitra-zz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xadupre @wschin @yuslepukhin @vinitra-zz @linkerzhang @jignparm @sdpython