Added helper script to call vcvarsall.bat found using vswhere.exe. - #1425
Closed
edgchen1 wants to merge 3 commits into
Closed
Added helper script to call vcvarsall.bat found using vswhere.exe.#1425edgchen1 wants to merge 3 commits into
edgchen1 wants to merge 3 commits into
Conversation
…dated existing usages of vcvarsall.bat.
snnn
reviewed
Jul 17, 2019
edgchen1
changed the title
|
This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details. |
|
This issue has been automatically closed due to inactivity. Please reactivate if further support is needed. |
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes
Fix cli argparse help format: tuple -> str. Now `olive -h` works
automatically.
```
➜ Olive git:(xiaoyu/cli) olive -h
usage: olive
positional arguments:
{run,auto-opt,capture-onnx-graph,finetune,generate-adapter,convert-adapters,quantize,tune-session-params,configure-qualcomm-sdk,manage-aml-compute,shared-cache}
run Run an olive workflow
auto-opt Automatically optimize the performance of the input model.
capture-onnx-graph Capture ONNX graph using PyTorch Exporter or Model Builder from the Huggingface model or
PyTorch model.
finetune Fine-tune a model on a dataset using peft. Huggingface training arguments can be provided
along with the defined options.
generate-adapter Generate ONNX model with adapters as inputs. Only accepts ONNX models.
convert-adapters Convert lora adapter weights to a file that will be consumed by ONNX models generated by
Olive ExtractedAdapters pass.
quantize Quantize the input model
tune-session-params
Automatically tune the session parameters for a given onnx model. Currently, for onnx model
converted from huggingface model and used for generative tasks, user can simply provide the
--model onnx_model_path --hf_model_name hf_model_name --device device_type to get the tuned
session parameters.
configure-qualcomm-sdk
Configure Qualcomm SDK for Olive
manage-aml-compute Create new compute in your AzureML workspace
shared-cache Shared cache model operations
options:
-h, --help show this help message and exit
```
## Checklist before requesting a review
- [ ] Add unit tests for this change.
- [ ] Make sure all tests can pass.
- [ ] Update documents if necessary.
- [ ] Lint and apply fixes to your code by running `lintrunner -a`
- [ ] Is this a user-facing change? If yes, give a description of this
change to be included in the release notes.
- [ ] Is this PR including examples changes? If yes, please remember to
update [example
documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md)
in a follow-up PR.
## (Optional) Issue link
microsoft/Olive#1405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added helper script to call vcvarsall.bat found using vswhere.exe. Updated existing usages of vcvarsall.bat.
Description:
This change adds some helper scripts for calling VS2017's vcvarsall.bat and updates existing calls to vcvarsall.bat. The locating of vcvarsall.bat is delegated to vswhere.exe (https://github.com/Microsoft/vswhere), which seems like a robust way of finding it.
Motivation and Context