Conversation
added 2 commits
July 23, 2019 15:50
jywu-mysoft
approved these changes
Jul 24, 2019
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes For the Olive release, in the ONNX export pass, since when `dynamo=True` the dynamic_shapes argument is not provided properly, we temporarily change the check to require torch 2.6 to enable the new `dynamo=True` logic pass. This way when a user has torch 2.5 Olive will still use the old `dynamo_export` logic and function without errors. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link - microsoft/Olive#1478
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add docs for the fns candy demo
Motivation and Context
Why is this change required? What problem does it solve?
The program has no doc. Should have one.
If it fixes an open issue, please link to the issue here.