Enable mklml openmp - #1480
Conversation
| set(ONNX_ML 1) | ||
|
|
||
| if(onnxruntime_USE_OPENMP) | ||
| if(onnxruntime_USE_OPENMP AND WIN32) |
There was a problem hiding this comment.
On Windows, it should be possible to only use Intel's OMP library (excluding VCOMP) when OMP and MKLML are both enabled. by using /link /nodefaultlib:vcomp libiomp5md.lib
see https://software.intel.com/en-us/cpp-compiler-developer-guide-and-reference-using-the-openmp-libraries#C28B029B-7E9F-46D7-8C84-38B0683236B9
|
Great! |
|
Need to hold on this PR. |
|
Is the unit of performance inference time (second)? |
|
Hi @WilliamZhaoz yes. |
Description:
Allow people build onnxruntime with openmp and mklml both.
Motivation and Context
We thought they have conflict, indeed they don't. It was just because we choose the wrong library to link.
On my machine, the mlperf resnet50 model,
(will post a full perf comparison matrix here. So far what I saw was pretty good)
Below is the perf data for OptimizationLevel= 3 and threadcount = 1 , with mklml