Move Class CudnnDropout to cudnn_common.h - #1492
Merged
Merged
Conversation
Hector Li (HectorSVC)
commented
Jul 24, 2019
Hector Li (HectorSVC)
commented
Contributor
- Move Class CudnnDropout to cudnn_common.h so that can share it with other ops. Move the cuda memory allocation part out of CudnnDropout to avoid memory leak.
- Move non_max_suppression_test.cc to object_detection folder
…ther ops. Move the cuda memory allocation part out of CudnnDropout to avoid memory leak.
Yufeng Li (yufenglee)
approved these changes
Jul 26, 2019
Dmitri Smirnov (yuslepukhin)
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes Fix Olive bugs & Add Bert inc examples to example pipeline. - `batch_size` is needed for Inc dataloader. Set default size to 1. - Custom eval func doesn't have batch_size as input. - For `QuantizationAwareTraining` pass, `train_data_config` is not required if user provides `training_loop_func`. - Latest transformers package will automatically save trained model as safetensors format. Add `save_safetensors` as false to train argument. - Some passes may have nested data_config in its config. Update auto-fill data_config logic to achieve this. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.