Update release branch directly to remove special casing of "None" as a dim_param - #1495
Closed
skottmckay wants to merge 1 commit into
Closed
Update release branch directly to remove special casing of "None" as a dim_param#1495skottmckay wants to merge 1 commit into
skottmckay wants to merge 1 commit into
Conversation
ke1337
approved these changes
Jul 25, 2019
hariharans29
approved these changes
Jul 25, 2019
yuslepukhin
deleted the
skottmckay/rel-0.5.0/RemoveSpecialCasingOfNoneAsDimParam
branch
August 6, 2019 17:03
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes Fix RUFF format ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Duplicate changes from #1482 on release branch
Motivation and Context
CI builds are extremely flaky currently and this change needs to get into the release asap. Duplicate the change so the release update isn't blocked on #1482 being commited on master and cherry-picked across to the release branch.