Rename Tensor.Size() to Tensor.SizeInBytes() - #1502
Merged
Merged
Conversation
Yufeng Li (yufenglee)
requested review from
Ke Deng (ke1337),
Ke Zhang (linkerzhang),
Scott McKay (skottmckay) and
snnn (snnn)
July 25, 2019 22:10
Scott McKay (skottmckay)
previously approved these changes
Jul 25, 2019
Ke Deng (ke1337)
previously approved these changes
Jul 25, 2019
Yufeng Li (yufenglee)
dismissed stale reviews from Ke Deng (ke1337) and Scott McKay (skottmckay)
via
July 26, 2019 00:19
f6e5831
Contributor
|
Hi Pranav Sharma (@pranavsharma), please review this PR. The renaming is a breaking change to our 1st partners. If you agree with this change, please help us coordinate with our partners and acknowledge them of this. Thanks. |
Contributor
|
LGTM. Will approve once the builds pass. |
Ke Zhang (linkerzhang)
approved these changes
Jul 26, 2019
Ke Zhang (linkerzhang)
left a comment
Ke Zhang (linkerzhang)
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Tensor.Size() returns its memory size in bytes instead of element size. The name is confusing. Rename it to SizeInBytes()
Motivation and Context