Fix regression with empty quote - #1508
Merged
Merged
Conversation
…a test command `gcc ... "" ...` failed while trying to compile a source file with empty name. ``` [user@******** /]# gcc "" gcc: error: : No such file or directory gcc: fatal error: no input files compilation terminated. ```
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1508 in repo microsoft/onnxruntime |
Contributor
Author
|
@jywu-msft Please help reviewing, thanks! |
Contributor
Author
|
It's really interesting to see this issue is not triggered in CI but applies locally for me. |
Contributor
Author
|
Besides, may I ask for permission to trigger CI? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 22 pipeline(s). |
Contributor
Author
|
CI failure in "Python Download" stage, unrelated. |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1508 in repo microsoft/onnxruntime |
xkszltl
added a commit
to xkszltl/Roaster
that referenced
this pull request
Jul 26, 2019
jywu-mysoft
approved these changes
Jul 26, 2019
Contributor
Author
|
Any thoughts about this error in Android build? |
Contributor
|
Unrelated. Android CI has been broken for awhile. (Will be fixed later) It's not a required pipeline so it won't block merge of this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty double quote
""is passed tofind_package(Thread), causing a test commandgcc ... "" ...failed while trying to compile a source file with empty name.This fixed the "Thread not found" issue in #1469