Skip to content

Fix regression with empty quote - #1508

Merged
jywu-mysoft merged 1 commit into
microsoft:masterfrom
xkszltl:thread
Jul 26, 2019
Merged

Fix regression with empty quote#1508
jywu-mysoft merged 1 commit into
microsoft:masterfrom
xkszltl:thread

Conversation

@xkszltl

@xkszltl xkszltl commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

Empty double quote "" is passed to find_package(Thread), causing a test command gcc ... "" ... failed while trying to compile a source file with empty name.

[user@******** /]# gcc ""
gcc: error: : No such file or directory
gcc: fatal error: no input files
compilation terminated.

This fixed the "Thread not found" issue in #1469

…a test command `gcc ... "" ...` failed while trying to compile a source file with empty name.

```
[user@******** /]# gcc ""
gcc: error: : No such file or directory
gcc: fatal error: no input files
compilation terminated.
```
@xkszltl
xkszltl requested a review from a team as a code owner July 26, 2019 03:42
@xkszltl

xkszltl commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 1508 in repo microsoft/onnxruntime

@xkszltl

xkszltl commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

@jywu-msft Please help reviewing, thanks!

@xkszltl

xkszltl commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

It's really interesting to see this issue is not triggered in CI but applies locally for me.
The code path for error is ort->mkldnn->gtest->cmake(thread).
FYI I'm using cmake 3.15.0, and the latest release of gtest is also build and installed by us instead of the upstream version in distro.

@xkszltl

xkszltl commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

Besides, may I ask for permission to trigger CI?

@jywu-mysoft

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 22 pipeline(s).

@xkszltl

xkszltl commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

CI failure in "Python Download" stage, unrelated.

@xkszltl

xkszltl commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 1508 in repo microsoft/onnxruntime

xkszltl added a commit to xkszltl/Roaster that referenced this pull request Jul 26, 2019
@xkszltl

xkszltl commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

Any thoughts about this error in Android build?

-- Using toolchain file: /android-ndk/build/cmake/android.toolchain.cmake.
-- Found PythonInterp: /usr/bin/python (found version "2.7.12") 
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
neural-networks-lib
    linked by target "dnnlibrary" in directory /onnxruntime_src/cmake/external/DNNLibrary/dnnlibrary

-- Configuring incomplete, errors occurred!

@jywu-mysoft

jywu-mysoft commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

Unrelated. Android CI has been broken for awhile. (Will be fixed later) It's not a required pipeline so it won't block merge of this PR

@jywu-mysoft
jywu-mysoft merged commit 33ae28c into microsoft:master Jul 26, 2019
@xkszltl
xkszltl deleted the thread branch July 26, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants