OP implementation: Round(11) - #1536
Closed
fs-eire wants to merge 1 commit into
Closed
Conversation
tracysh
reviewed
Aug 1, 2019
| Round, | ||
| 11, | ||
| float, | ||
| KernelDefBuilder().TypeConstraint("T", DataTypeImpl::GetTensorType<float>()), |
Contributor
There was a problem hiding this comment.
Can these kernels be declared with MayInplace(0, 0)? The implementation would seem to support that.
Contributor
Author
There was a problem hiding this comment.
It looks like no MayImplace is declared in this file for other similar operators (eg. Abs, all trigonometric functions) in this files. Is there any reason for not doing that?
If Round is not the only operator to apply MayImplace, I would like to add the declarations to all applicable operators in a separated PR.
Contributor
|
Seems replaced by #1705, is this PR still need? |
Contributor
Author
Close this PR. |
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes Add `onnxscript` and `onnxoptimizer` optimize API details to the document. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add implementation of operator
Round(opset 11)Motivation and Context