Fix some build issues on MacOS with Xcode 14.3. - #15878
Merged
Merged
Conversation
snnn
reviewed
May 15, 2023
Contributor
|
Related #15599 |
snnn
previously approved these changes
May 18, 2023
snnn
dismissed
their stale review
May 18, 2023 02:34
Need to figure out how to resolve the iconv issue.
edgchen1
marked this pull request as draft
May 18, 2023 03:32
This reverts commit 0a185d3.
edgchen1
commented
May 18, 2023
edgchen1
marked this pull request as ready for review
May 18, 2023 23:50
…nto edgchen1/fix_mac_build_issues
snnn
suggested changes
May 23, 2023
edgchen1
commented
May 31, 2023
Contributor
|
/azp run orttraining-linux-ci-pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 2, 2023
vraspar
approved these changes
Jun 7, 2023
Honry
pushed a commit
to Honry/onnxruntime
that referenced
this pull request
Jun 8, 2023
- Fix flatbuffers flatc warning, unused-but-set-variable. - Address `-Wshorten-64-to-32` warnings (fix in our code, allow in dependencies' code). - Update CI builds to use Xcode 14.3. - Update minimum iOS version to 12.0. - Update Mac hosted agents to MacOS 13 where possible.
Merged
titaiwangms
added a commit
that referenced
this pull request
Jun 28, 2025
ankus-qti
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
Delete the legacy patches related to protobuf, which was added from microsoft#14279 and microsoft#15878 to simplify the ONNX patches.
qti-jkilpatrick
pushed a commit
to onnxruntime/onnxruntime-qnn
that referenced
this pull request
Jan 26, 2026
Delete the legacy patches related to protobuf, which was added from microsoft/onnxruntime#14279 and microsoft/onnxruntime#15878 to simplify the ONNX patches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Wshorten-64-to-32warnings (fix in our code, allow in dependencies' code).Motivation and Context
Fix local build.
Fix #16221.