Increase max error tolerance for ConvTransposeGrad test - #17315
Merged
baijumeswani merged 1 commit intoAug 29, 2023
Conversation
baijumeswani
added
training
Lafi7e
approved these changes
Aug 29, 2023
baijumeswani
deleted the
baijumeswani/convtransposegrad-increase-tolerance
branch
August 29, 2023 00:05
pengwa
reviewed
Aug 29, 2023
| OpDef op_def{"ConvTranspose"}; | ||
|
|
||
| float error_tolerance = 1e-1f; | ||
| float error_tolerance = 3e-1f; |
Contributor
There was a problem hiding this comment.
A quick question: we defined a relatively higher tolerance for ConvTransposeGradientCheckerTest and ConvGradientCheckerTest, is there any explanation for it, I mean, is it expected for the small-sized test inputs?
Contributor
Author
There was a problem hiding this comment.
I don't have a good answer for this question. @er3x3 do you have an answer for this? I could only speculate. I can probably delve deeper and find an answer to this, but I don't know as of now.
Contributor
There was a problem hiding this comment.
cuDNN is non-deterministic, while the expected values are computed on CPU.
Lafi7e
pushed a commit
that referenced
this pull request
Sep 1, 2023
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #17201 (comment)
Making the tolerance the same as the ConvGrad tests.