Fix NNAPI optional input handling checks and unblock Android CI pipeline test failures - #17358
Merged
Conversation
YUNQIUGUO
marked this pull request as ready for review
August 30, 2023 22:19
YUNQIUGUO
marked this pull request as draft
August 30, 2023 22:20
Contributor
Author
|
Currently, Resize Op unit tests still have one I don't have much context. Not sure if we should just disable nnapi ep in this test case. Details: It does not "fail" before, as the op is not actually assigned to NNAPI EP due to cc @wejoncy |
edgchen1
reviewed
Aug 30, 2023
YUNQIUGUO
marked this pull request as ready for review
August 31, 2023 02:09
skottmckay
reviewed
Aug 31, 2023
skottmckay
reviewed
Aug 31, 2023
added 3 commits
August 31, 2023 10:50
edgchen1
previously approved these changes
Aug 31, 2023
Lafi7e
pushed a commit
that referenced
this pull request
Sep 1, 2023
…ine test failures (#17358) ### Description <!-- Describe your changes. --> - Fix missing optional input checks originally coming from a github issue for no shape on Resize Op. - Exclude Antialias support for Opset 18 + Resize for NNAPI - Unblock Android CI pipeline tests failure. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Bug fixes. Issue: #17035 thanks @skottmckay for pointing out the cause. --------- Co-authored-by: rachguo <rachguo@rachguos-Mini.attlocal.net> Co-authored-by: rachguo <rachguo@rachguos-Mac-mini.local>
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…ine test failures (microsoft#17358) ### Description <!-- Describe your changes. --> - Fix missing optional input checks originally coming from a github issue for no shape on Resize Op. - Exclude Antialias support for Opset 18 + Resize for NNAPI - Unblock Android CI pipeline tests failure. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Bug fixes. Issue: microsoft#17035 thanks @skottmckay for pointing out the cause. --------- Co-authored-by: rachguo <rachguo@rachguos-Mini.attlocal.net> Co-authored-by: rachguo <rachguo@rachguos-Mac-mini.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Bug fixes.
Issue:
#17035
thanks @skottmckay for pointing out the cause.