Cherry-picks pipeline changes to 1.16.0 release branch - #17577
Merged
Conversation
added 7 commits
September 15, 2023 16:47
Delete all Prefast tasks because the new VS 17.7 version crashes every time when we run the task on our CI build servers. However, we cannot reproduce it locally. And this problem blocks us installing security patches to our CI build machines. Will use [CodeQL](https://codeql.github.com/) instead. Address some security alerts.
### Description Resolve #9754
### Description The files should not have the minor version number. The names were added in #17365 by mistake. ### Motivation and Context We did not successfully exclude them out.
snnn
marked this pull request as draft
September 15, 2023 21:36
Contributor
Author
|
I'm waiting for pipelines to finish. |
snnn
marked this pull request as ready for review
September 16, 2023 03:41
jywu-mysoft
reviewed
Sep 17, 2023
mszhanyi
approved these changes
Sep 18, 2023
pranavsharma
approved these changes
Sep 18, 2023
pranavsharma
left a comment
pranavsharma
left a comment
Contributor
There was a problem hiding this comment.
Reviewing on George's behalf.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main problem I'm trying to solve is: our GPU package depends on both CUDA 11.x and CUDA 12.x . However, it's not easy to see the information because ldd doesn't work with the shared libraries we generate(see issue #9754) . So the patchelf change are useful for me to validate the "Disabling yum update" was successful. As you can see we call "yum update" from multiple places. Without some kind of validation it's hard to say if I have covered all of them.
The Prefast change is needed because I'm going to update the VM images in the next a few weeks. In case of we need to publish a patch release after that.
Motivation and Context
Without this fix we will mix using CUDA 11.x and CUDA 12.x. And it will crash every time when we use TensorRT.