Skip to content

Fix Android CI build (onnx model test still broken) - #1779

Closed
shahasad wants to merge 20 commits into
masterfrom
dev/shahasad/fix-android-ci
Closed

Fix Android CI build (onnx model test still broken)#1779
shahasad wants to merge 20 commits into
masterfrom
dev/shahasad/fix-android-ci

Conversation

@shahasad

@shahasad shahasad commented Sep 8, 2019

Copy link
Copy Markdown
Contributor

Description: Describe your changes.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@shahasad
shahasad requested a review from a team as a code owner September 8, 2019 01:31
@daquexian

Copy link
Copy Markdown
Contributor

What is the relation between this PR and #1600?

@shahasad

shahasad commented Sep 8, 2019

Copy link
Copy Markdown
Contributor Author

@daquexian I did not notice #1600.
Please feel free to merge relevant changes from here to (#1600). Main purpose is to get the Android CI back running.

@daquexian

Copy link
Copy Markdown
Contributor

@shahasad Thanks for the clarification. In fact, I think #1600 already gets Android CI working, however, a workaround for cmake 3.15 seems break it again. I will fix it soon.

@daquexian

daquexian commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

@shahasad I made Android CI working in #1600 :)

@snnn

snnn commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

Is this PR still needed?

@snnn snnn closed this Oct 24, 2019
yuslepukhin pushed a commit that referenced this pull request Mar 17, 2026
Implement ir_model_to_olive_model for improved ONNX IR support. Users
can now use the function directly to create an Olive model from an
ir.Model without having to go through onnx protobuf methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants