[Quantization] Fix get_qnn_qdq_config to use new scale/zp np.array data types - #19114
Merged
Conversation
Contributor
Author
|
@yufenglee @xadupre Just letting you know about this regression. Added a unit test to help catch future issues (I should have added it initially). |
jywu-mysoft
approved these changes
Jan 12, 2024
xadupre
approved these changes
Jan 12, 2024
Member
|
Thanks. Sorry if i missed some places where numpy types are missing. I did that change to make it easier to carry information about the weight type and quantized type to be able to handle more weight types and more quantized types in the future.
Xavier
Envoyé à partir de Outlook pour Android<https://aka.ms/AAb9ysg>
…________________________________
From: Adrian Lizarraga ***@***.***>
Sent: Friday, January 12, 2024 10:08:11 PM
To: microsoft/onnxruntime ***@***.***>
Cc: Xavier Dupre ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/onnxruntime] [Quantization] Fix get_qnn_qdq_config to use new scale/zp np.array data types (PR #19114)
@yufenglee<https://github.com/yufenglee> @xadupre<https://github.com/xadupre> Just letting you know about this regression. Added a unit test to help catch future issues.
—
Reply to this email directly, view it on GitHub<#19114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFLJULN23KYLWBR7B3FY5L3YOGQ3XAVCNFSM6AAAAABBYWGTT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZHE2TANBXG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
Author
No worries, I really should have added more/better tests in the first place :) |
mszhanyi
pushed a commit
that referenced
this pull request
Jan 15, 2024
…ta types (#19114) ### Description - Updates `get_qnn_qdq_config()` to use new scale/zp np.array data types. - Adds missing unit test to help prevent future regression. ### Motivation and Context #18043 changed the usage of `extra_options["TensorQuantizationOverrides"]`. We need to update its use in quantization/execution_providers/qnn/quant_config.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
get_qnn_qdq_config()to use new scale/zp np.array data types.Motivation and Context
#18043 changed the usage of
extra_options["TensorQuantizationOverrides"]. We need to update its use in quantization/execution_providers/qnn/quant_config.py