Skip to content

Undo integration test skip - #1917

Merged
shahasad merged 3 commits into
microsoft:masterfrom
pulkittomar:user/putomargit/FixIntegrationtest
Oct 27, 2019
Merged

Undo integration test skip#1917
shahasad merged 3 commits into
microsoft:masterfrom
pulkittomar:user/putomargit/FixIntegrationtest

Conversation

@pulkittomar

@pulkittomar pulkittomar commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

TestModelSerialization was skipped due to Linux CI build failures. The Linux CI build were disabled so these tests didn't execute before the checkin.

After merging the latest master, I see the TestModelSerialization test no longer fails.

The test failed consistently for one of the nightly builds. There were some change in C++ api which update graph optimization level enums. After taking all the latest changes in master, I see that the test passed. I believe the tests failed because API was in an inconsistent state.

Test run:
1_Linux_CI_Dev (1).txt:113480:2019-09-26T00:42:45.4241477Z 2: [ OK ] InferenceSessionTests.NoTimeout (1 ms)
1_Linux_CI_Dev (1).txt:113481:2019-09-26T00:42:45.4241900Z 2: [ RUN ] InferenceSessionTests.DisableCPUArena
1_Linux_CI_Dev (1).txt:113482:2019-09-26T00:42:45.4252498Z 2: [ OK ] InferenceSessionTests.DisableCPUArena (1 ms)

1_Linux_CI_Dev (1).txt:113483:2019-09-26T00:42:45.4252926Z 2: [ RUN ] InferenceSessionTests.TestModelSerialization
1_Linux_CI_Dev (1).txt:113484:2019-09-26T00:42:45.4292801Z 2: 2019-09-26 00:42:45.428682970 [W:onnxruntime:InferenceSessionTests.TestModelSerialization, inference_session.cc:540 Initialize] Serializing Optimized ONNX model with Graph Optimization level greater than 2
is not supported.
1_Linux_CI_Dev (1).txt:113485:2019-09-26T00:42:45.4331794Z 2: [ OK ] InferenceSessionTests.TestModelSerialization (8 ms)
1_Linux_CI_Dev (1).txt:113486:2019-09-26T00:42:45.4332396Z 2: [ RUN ] InferenceSessionTests.ModelMetadata
1_Linux_CI_Dev (1).txt:113487:2019-09-26T00:42:45.4430817Z 2: weights size: 52 inputs.size(): 1 from session: 1
1_Linux_CI_Dev (1).txt:113488:2019-09-26T00:42:45.4442183Z 2: [ OK ] InferenceSessionTests.ModelMetadata (11 ms)
1_Linux_CI_Dev (1).txt:118147:2019-09-26T00:43:55.1921083Z 2: [ OK ] InferenceSessionTests.NoTimeout (7 ms)
1_Linux_CI_Dev (1).txt:118148:2019-09-26T00:43:55.1921572Z 2: [ RUN ] InferenceSessionTests.DisableCPUArena
1_Linux_CI_Dev (1).txt:118149:2019-09-26T00:43:55.1981113Z 2: [ OK ] InferenceSessionTests.DisableCPUArena (6 ms)
1_Linux_CI_Dev (1).txt:118150:2019-09-26T00:43:55.1981524Z 2: [ RUN ] InferenceSessionTests.TestModelSerialization
1_Linux_CI_Dev (1).txt:118151:2019-09-26T00:43:55.2077456Z 2: 2019-09-26 00:43:55.207010552 [W:onnxruntime:InferenceSessionTests.TestModelSerialization, inference_session.cc:540 Initialize] Serializing Optimized ONNX model with Graph Optimization level greater than 2
is not supported.
1_Linux_CI_Dev (1).txt:118152:2019-09-26T00:43:55.2361048Z 2: [ OK ] InferenceSessionTests.TestModelSerialization (38 ms)
1_Linux_CI_Dev (1).txt:118153:2019-09-26T00:43:55.2361493Z 2: [ RUN ] InferenceSessionTests.ModelMetadata
1_Linux_CI_Dev (1).txt:118154:2019-09-26T00:43:55.2528171Z 2: weights size: 52 inputs.size(): 1 from session: 1
1_Linux_CI_Dev (1).txt:118155:2019-09-26T00:43:55.2580029Z 2: [ OK ] InferenceSessionTests.ModelMetadata (22 ms)
Linux_CI_Dev\8_Command Line Script.txt:112574:2019-09-26T00:42:45.4241451Z 2: [ OK ] InferenceSessionTests.NoTimeout (1 ms)
Linux_CI_Dev\8_Command Line Script.txt:112575:2019-09-26T00:42:45.4241890Z 2: [ RUN ] InferenceSessionTests.DisableCPUArena
Linux_CI_Dev\8_Command Line Script.txt:112576:2019-09-26T00:42:45.4252471Z 2: [ OK ] InferenceSessionTests.DisableCPUArena (1 ms)
Linux_CI_Dev\8_Command Line Script.txt:112577:2019-09-26T00:42:45.4252917Z 2: [ RUN ] InferenceSessionTests.TestModelSerialization
Linux_CI_Dev\8_Command Line Script.txt:112578:2019-09-26T00:42:45.4292773Z 2: 2019-09-26 00:42:45.428682970 [W:onnxruntime:InferenceSessionTests.TestModelSerialization, inference_session.cc:540 Initialize] Serializing Optimized ONNX model with Graph Optimization
level greater than 2 is not supported.
Linux_CI_Dev\8_Command Line Script.txt:112579:2019-09-26T00:42:45.4331767Z 2: [ OK ] InferenceSessionTests.TestModelSerialization (8 ms)
Linux_CI_Dev\8_Command Line Script.txt:112580:2019-09-26T00:42:45.4332228Z 2: [ RUN ] InferenceSessionTests.ModelMetadata
Linux_CI_Dev\8_Command Line Script.txt:112581:2019-09-26T00:42:45.4430789Z 2: weights size: 52 inputs.size(): 1 from session: 1
Linux_CI_Dev\8_Command Line Script.txt:112582:2019-09-26T00:42:45.4442139Z 2: [ OK ] InferenceSessionTests.ModelMetadata (11 ms)
Linux_CI_Dev\8_Command Line Script.txt:117241:2019-09-26T00:43:55.1920856Z 2: [ OK ] InferenceSessionTests.NoTimeout (7 ms)
Linux_CI_Dev\8_Command Line Script.txt:117242:2019-09-26T00:43:55.1921563Z 2: [ RUN ] InferenceSessionTests.DisableCPUArena
Linux_CI_Dev\8_Command Line Script.txt:117243:2019-09-26T00:43:55.1981056Z 2: [ OK ] InferenceSessionTests.DisableCPUArena (6 ms)
Linux_CI_Dev\8_Command Line Script.txt:117244:2019-09-26T00:43:55.1981515Z 2: [ RUN ] InferenceSessionTests.TestModelSerialization
Linux_CI_Dev\8_Command Line Script.txt:117245:2019-09-26T00:43:55.2077428Z 2: 2019-09-26 00:43:55.207010552 [W:onnxruntime:InferenceSessionTests.TestModelSerialization, inference_session.cc:540 Initialize] Serializing Optimized ONNX model with Graph Optimization
level greater than 2 is not supported.
Linux_CI_Dev\8_Command Line Script.txt:117246:2019-09-26T00:43:55.2361019Z 2: [ OK ] InferenceSessionTests.TestModelSerialization (38 ms)
Linux_CI_Dev\8_Command Line Script.txt:117247:2019-09-26T00:43:55.2361482Z 2: [ RUN ] InferenceSessionTests.ModelMetadata
Linux_CI_Dev\8_Command Line Script.txt:117248:2019-09-26T00:43:55.2528140Z 2: weights size: 52 inputs.size(): 1 from session: 1
Linux_CI_Dev\8_Command Line Script.txt:117249:2019-09-26T00:43:55.2580003Z 2: [ OK ] InferenceSessionTests.ModelMetadata (22 ms)

This PR is attempting to address the CSharp api failures for those tests.

@pulkittomar
pulkittomar requested a review from a team as a code owner September 25, 2019 12:37

@shahasad shahasad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the test actually fixed?

@shahasad

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 19 pipeline(s).

@askhade

askhade commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 12 pipeline(s).

Comment thread csharp/test/Microsoft.ML.OnnxRuntime.Tests/InferenceTest.cs
Pulkit Tomar and others added 2 commits October 25, 2019 12:05
@shahasad

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 12 pipeline(s).

@shahasad
shahasad merged commit 1fa956f into microsoft:master Oct 27, 2019
yuslepukhin pushed a commit that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants