Fix Onnx >= to == - #20798
Merged
Merged
Conversation
snnn (snnn)
approved these changes
May 24, 2024
snnn (snnn)
left a comment
snnn (snnn)
left a comment
Contributor
There was a problem hiding this comment.
In general we should prefer to use "==" instead of ">=", unless we are pretty sure a new version of the package would not break our pipeline.
Tianlei Wu (tianleiwu)
approved these changes
May 24, 2024
Sophie Schoenmeyer (sophies927)
added
the
triage:approved
Yifan Li (yf711)
pushed a commit
that referenced
this pull request
Jun 18, 2024
### Description <!-- Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Yifan Li (yf711)
pushed a commit
that referenced
this pull request
Jun 18, 2024
### Description <!-- Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context