Skip to content

Remove failOnStderr from Gradle cmakeCheck - #20919

Merged
Jian Chen (jchen351) merged 1 commit into
mainfrom
Cjian/gradle-fix
Jun 4, 2024
Merged

Remove failOnStderr from Gradle cmakeCheck#20919
Jian Chen (jchen351) merged 1 commit into
mainfrom
Cjian/gradle-fix

Conversation

@jchen351

Copy link
Copy Markdown
Contributor

Description

Remove failOnStderr from Gradle cmakeCheck

Motivation and Context

The Gradle is still using the deprecated API

@jchen351
Jian Chen (jchen351) requested a review from a team June 4, 2024 16:32
@snnn

Copy link
Copy Markdown
Contributor

The Gradle is still using the deprecated API

What does it mean? Should we upgrade Gradle?

@jchen351

Copy link
Copy Markdown
Contributor Author

The Gradle is still using the deprecated API

What does it mean? Should we upgrade Gradle?

The current stable gradle version is 8.8. But these have to be fixed before gradle 9 is offical released.

@edgchen1

Copy link
Copy Markdown
Contributor

Is our Gradle code using deprecated APIs which are causing some warning output? If so, what are the deprecated APIs and can our usage of them be updated?

@jchen351

Copy link
Copy Markdown
Contributor Author

Is our Gradle code using deprecated APIs which are causing some warning output? If so, what are the deprecated APIs and can our usage of them be updated?

the usage like project.buildDir need to be changed to project.layout.buildDirectory

@jchen351

Copy link
Copy Markdown
Contributor Author

Will try to fix deprecated Gradle usages in a separated PR

@jchen351
Jian Chen (jchen351) merged commit 5faeaf6 into main Jun 4, 2024
@jchen351
Jian Chen (jchen351) deleted the Cjian/gradle-fix branch June 4, 2024 20:54
@sophies927 Sophie Schoenmeyer (sophies927) added the triage:approved Approved for cherrypicks for release label Jun 11, 2024
Yifan Li (yf711) pushed a commit that referenced this pull request Jun 18, 2024
### Description
Remove failOnStderr from Gradle cmakeCheck



### Motivation and Context
The Gradle is still using the deprecated API
Yifan Li (yf711) pushed a commit that referenced this pull request Jun 18, 2024
### Description
Remove failOnStderr from Gradle cmakeCheck



### Motivation and Context
The Gradle is still using the deprecated API
Baiju Meswani (baijumeswani) pushed a commit that referenced this pull request Jun 20, 2024
### Description
Remove failOnStderr from Gradle cmakeCheck



### Motivation and Context
The Gradle is still using the deprecated API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:1.18.1 triage:approved Approved for cherrypicks for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants