MKLDNN 1.0.2 - #2102
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 20 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 20 pipeline(s). |
|
|
||
| // temporary switch to toggle between mkldnn-vanilla and mkldnn-subgraph implementation using | ||
| // ORT_MKLDNN_SUBGRAPH environment variable | ||
| // |
| mkldnn::engine& cpu_engine, | ||
| std::vector<mkldnn::primitive>& net, | ||
| mkldnn::memory::format& source_format) { | ||
| std::vector<std::unordered_map<int, mkldnn::memory>> &net_args) { |
There was a problem hiding this comment.
nit: & should be after >>
| int subgraph_index = 0; | ||
|
|
||
| void Reset() { | ||
| SubgraphVariables() { |
There was a problem hiding this comment.
why is this needed? i thought we got rid of it in #1740
|
looks like the windows build fails. |
Looking at it. cloned MKL-DNN 1.0.2 is failing. It builds for me on my dev box. |
| namespace onnxruntime { | ||
| namespace mkl_dnn { | ||
|
|
||
| #define MKLDNN_EP_LRU_CACHE_DEFAULT_SIZE 500 |
There was a problem hiding this comment.
this will be implemented later right? remove for now.
| ort_source_desc_ = mkldnn::memory::desc( | ||
| {src_dims}, MklDnnType<T>(), ort_source_format_); | ||
| source_desc_ = ort_source_desc_; | ||
| src_md_.reset(new mkldnn::memory::desc( |
There was a problem hiding this comment.
we can take this opportunity to clean up the smart pointer usage in all these files.
src_md_ = make_shared(...) is preferred and more efficient than reset(new T)
let's clean all this up. thanks.
There was a problem hiding this comment.
Most of the pointers are unique_ptr and we need make_unique.
I was about to push my changes. I will make these changes and then create a new PR
There was a problem hiding this comment.
Most of the pointers are unique_ptr and we need make_unique.
I was about to push my changes. I will make these changes and then create a new PR
let's do the cleanup as a separate PR then. priority is to get this one passing the CI's and merged soon.
There was a problem hiding this comment.
okay. I will close this and create new new PR. As I have merged latest from master repo.
|
Creating new PR |
## Describe your changes - Not used at all and maintained. - Same as #2101 but additional files removed ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
2 participants
Upgrading MKL-DNN EP to MKL-DNN 1.0.2