Fix lint C++ actions - #21303
Merged
Merged
Conversation
snnn
previously approved these changes
Jul 10, 2024
Contributor
|
/azp run MacOS CI Pipeline , orttraining-mac-ci-pipeline |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
There are still many C++ lint warnings, let's fix them step by step, otherwise it is not practical to get reviewed. |
snnn
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
83e0c6b is the last commit having Lint C++ actions pass.
4a7eaff is the first commit let it fail.
Reviewdog/action-cpplint@master changed since that day. https://github.com/reviewdog/action-cpplint/pull/42/files make action-cpplint starts using reviewdog release https://github.com/reviewdog/reviewdog/releases/tag/v0.19.0.
Optional Lint also failed with many typos, should be also related to the same reason. Let's fix that in different prs.
Motivation and Context