fix: respect onnxruntime_USE_PREINSTALLED_EIGEN option - #22057
Closed
cloudhan wants to merge 1 commit into
Closed
Conversation
Contributor
|
When the option is set, user should also set "eigen_SOURCE_PATH" to point to a preinstalled eigen path. This is how the option was used in the past. |
snnn
reviewed
Sep 12, 2024
| endif() | ||
|
|
||
| find_package(Eigen3 CONFIG) | ||
| if (onnxruntime_USE_PREINSTALLED_EIGEN) |
Contributor
There was a problem hiding this comment.
onnxruntime_USE_PREINSTALLED_EIGEN is not used for indicating whether find_package should be used for looking for Eigen or not. It is a deprecated feature. I even couldn't remember why it was added. It is used with another cmake variable.
By default, cmake always call find_package first, unless FETCHCONTENT_TRY_FIND_PACKAGE_MODE is set to NEVER.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #21348, eigen find logic is changed if the eigen package is present on the system, causing
Because if find the very old version of eigen which do not have the
emplace_backdefined.