Skip to content

allow build flag --use_external_dawn - #22552

Merged
fs-eire merged 2 commits into
fs-eire/webgpu-epfrom
fs-eire/webgpu-ep-dawn-ext
Oct 24, 2024
Merged

allow build flag --use_external_dawn#22552
fs-eire merged 2 commits into
fs-eire/webgpu-epfrom
fs-eire/webgpu-ep-dawn-ext

Conversation

@fs-eire

@fs-eire fs-eire commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Description

introduce this build flag --use_external_dawn to allow specifying Dawn as an external dependency. When it is specified, dawn::native is excluded from build of onnxruntime, and passing in dawn proc table is required.

I didn't find a good way to run the test. Currently I need to build with the following flags:

C:\code\onnxruntime>build --use_webgpu --use_external_dawn --skip_tests --target onnxruntime_webgpu_external_dawn_test

And run the test using:

# run test that passing dawn proc table. expect session to initialize successfully
C:\code\onnxruntime\build\Windows\Debug\Debug>onnxruntime_webgpu_external_dawn_test.exe

# run test that does not pass proc table. expect exception to throw.
C:\code\onnxruntime\build\Windows\Debug\Debug>onnxruntime_webgpu_external_dawn_test.exe --no_proc_table

Comment thread onnxruntime/test/webgpu/external_dawn/main.cc
@fs-eire
fs-eire requested a review from a team October 24, 2024 06:09
@fs-eire
fs-eire merged commit a00f5b8 into fs-eire/webgpu-ep Oct 24, 2024
@fs-eire
fs-eire deleted the fs-eire/webgpu-ep-dawn-ext branch October 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants