Skip to content

[webgpu] allow early release staging buffer for uploads - #23947

Closed
fs-eire wants to merge 2 commits into
mainfrom
fs-eire/buffer-upload
Closed

[webgpu] allow early release staging buffer for uploads#23947
fs-eire wants to merge 2 commits into
mainfrom
fs-eire/buffer-upload

Conversation

@fs-eire

@fs-eire fs-eire commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Description

Allow early release of the upload staging buffers. Helps to reduce GPU memory usage

Thanks to #23910, when I looked at the code I found that this optimization is not yet done. The same optimization was done to JSEP in #22726.

Comment thread onnxruntime/core/providers/webgpu/buffer_manager.cc

@qjia7 qjia7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@fs-eire

fs-eire commented Mar 11, 2025

Copy link
Copy Markdown
Contributor Author

Interesting... the mac test failure seems stably reproducible. need investigation on mac

@fs-eire

fs-eire commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

merged as a part of #23968

@fs-eire fs-eire closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ep:WebGPU ort-web webgpu provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants