[webgpu] Refactor MatMulNBitsWideTileProgram shader - #25233
Closed
daijh wants to merge 0 commit into
Closed
Conversation
Contributor
Author
|
@sushraja-msft @qjia7 pls take a look. |
Contributor
Author
|
Heads-up: The following is a pre-existing issue. |
Contributor
|
@daijh Are you ok to hold on a while and use the template to refactor the shader base on @fs-eire 's this PR #25130? I think the template's result will be more readable. And it's a good start for this PR. I suppose PR #25130 will be merged soon. But if it's not the case or this will block you too much, please let me know. |
Contributor
Author
|
Sure. It's fine for me to apply the new template. |
Contributor
|
The WGSL template PR is merged. Please update to latest main branch and give it a try. |
Contributor
Author
|
Accidentally closed. Continuing work in PR #25353. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit refactors the
MatMulNBitsWideTileProgramshader to improve code readability and enables more flexible data handling.As part of this change, support for 4-bit and 8-bit shaders has been consolidated, and a common
CEIL_DIVutility has been introduced. The previousShaderUsage::UseUniformandShaderUsage::UseIndicesTypeAliasflags are no longer necessary and have been removed.Motivation and Context
See above.