fix: packaging onnxruntime for macOS x86-64 - #27968
Conversation
|
@microsoft-github-policy-service agree |
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Updates the macOS CI configuration to keep Intel (x86_64) builds running now that macos-13 is deprecated, and restores native Intel runners for the x86_64 CoreML/WebGPU build jobs.
Changes:
- Switch reusable macOS CI workflow x86_64 runner from
macos-13tomacos-15-intel(arm64 remainsmacos-15). - Standardize the reusable workflow’s Xcode selection to version
16to align with macOS 15 runners. - Update
mac.ymlCoreML and WebGPU matrices to run x86_64 builds on x86_64 machines (instead of arm64 machines targeting x86_64).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/macos-ci-build-and-test-workflow.yml | Moves x86_64 jobs to macos-15-intel and aligns Xcode selection for macOS 15 images. |
| .github/workflows/mac.yml | Restores native Intel execution for x86_64 CoreML/WebGPU CI jobs by updating the matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JellyBrick
changed the title
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Commenter does not have sufficient privileges for PR 27968 in repo microsoft/onnxruntime |
|
Hi folks.. this might not need to be the responsibility of a community member - perhaps MS should check this out and fix this bug - used the wrong arch type for build. |
|
Looks like conflicts now as branch has become stale |
PR #29502 replicates upstream #27968 which adds onnxruntime-java-osx-x86_64 to run_packaging's CPU platform list. Update jar_packaging_test.py's CPU fixture to create the corresponding artifact directory and libcustom_op_library.dylib, and extend the post-run cleanup assertion so the test verifies the file is consumed from the osx-x86_64 slot (archive_lib=True) like linux-x64 and osx-arm64. GPU fixture is unchanged since GPU's package_definitions still only touches onnxruntime-java-linux-x64. Addresses Copilot review comment on PR #29502.
|
Is this issue still being pushed forward? |
A couple of CI pipelines are failing - both on this PR and my own variant of this PR #29502 (which is a superset of this PR). I kicked off Nuget packagaing pipeline for my PR which seems to failthe Nuget packaging pipeline. Not sure if they are related to this PR (probably yes -because all other PRs seem to go through). I ll need to find some time to investigate this. |
This is because some of the test code for macOS in onnxruntime assumes an aarch64 (arm64) architecture. While this issue requires additional fixes, I’m not entirely sure whether it should be addressed within the scope of this PR. |
That is true for the CIs. As you can see from the other PR (#29502), I tried running some packaging pipelines that run as part of another set of pipelines that are run prior to every release. It is failing one of that. I have bought it to the attention of some folks who are more familiar with that. |
|
Also my colleagues just pointed out that removal of support for x86_64 Mac for ORT pckages was announced previously: 
|
|
But why? x86_64 is still actively supported on macOS, at least up to macOS 27. |
Description
macos-13is now deprecated.Motivation and Context
Ref [macOS] The macOS 13 Ventura based runner images will begin deprecation on September 22nd and will be fully unsupported by December 4th for GitHub and ADO actions/runner-images#13046
Ref [build] do not use x86 mac machines anymore #26072
Close [Build] onnxruntime-node no longer shipping x86-64 since 1.23.x #27961
Caused by Move macOS build jobs to a dedicated pool #26252