Additional validation in LSTM and DynamicQuantizedLSTM - #29595
Merged
Conversation
Xavier Dupré (xadupre)
previously approved these changes
Jul 7, 2026
Skip DML and QNN as they're no longer maintained in this repo.
The self-hosted runners (1ES.Pool=onnxruntime-github-Ubuntu2204-AMD-CPU) cannot reach registry.npmjs.org, causing 'npm install -g detox-cli' to time out with ETIMEDOUT. Configure both the Android and iOS jobs to use the internal feed at https://packagefeedproxy.microsoft.io/npm/ via the registry-url parameter on actions/setup-node.
…29703) ### Description `Test Linux TensorRT x64 Release` failed in `CApiTest.basic_cuda_graph` because the third replay returned stale output after input update. This change aligns `basic_cuda_graph` with the annotated CUDA graph test path by using one persistent `Ort::RunOptions` object across all runs. - **Failure addressed** - `onnxruntime_shared_lib_test` / `CApiTest.basic_cuda_graph` expected updated replay output (`{10, 40, 90, 160, 250, 360}`) but observed initial output (`{1, 4, 9, 16, 25, 36}`). - **Code change** - In `onnxruntime/test/shared_lib/test_inference.cc`, instantiate `Ort::RunOptions run_option;` once in `CApiTest.basic_cuda_graph`. - Replace per-call temporaries (`Ort::RunOptions()`) with the shared `run_option` in all three `session.Run(...)` invocations. - **Representative snippet** ```cpp Ort::RunOptions run_option; session.Run(run_option, binding); // capture session.Run(run_option, binding); // replay session.Run(run_option, binding); // replay after input update ``` ### Motivation and Context The failing TensorRT Linux Actions job was isolated to `basic_cuda_graph`, and the behavior diverged from the passing annotated CUDA graph path that already reuses a persistent `RunOptions`. Unifying this usage removes the mismatch in graph replay setup for this test scenario and addresses the observed stale-output failure. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
…/onnxruntime into skottmckay/MSRC_125531
Scott McKay (skottmckay)
enabled auto-merge (squash)
July 17, 2026 21:17
Edward Chen (edgchen1)
approved these changes
Jul 17, 2026
This was referenced Aug 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate weights against hidden_size attribute for LSTM and DynamicQuantizedLSTM to prevent OOB heap read
Motivation and Context
MSRC 125531