Hoist CropAndResize index offset to a named int64_t

[Ti-Tai Wang (titaiwangms)]

Description

Follow-up to the merged #29605, addressing a review nit from Akshay Sonawane (@apsonawane) on the base-offset index arithmetic in CropAndResizeForward.

The suggestion was that the static_cast<int64_t>(...) around the per-channel base offset looked redundant. It turns out the cast could not simply be removed: the offset expression is a SafeInt<int64_t>, and pointer + SafeInt<int64_t> is ambiguous — SafeInt exposes many implicit conversion operators (char, short, int, …), so the operand for pointer arithmetic cannot be resolved unambiguously (and SafeInt's own operator+(U, SafeInt) tries to treat the pointer as an integer). The cast was therefore load-bearing.

To honor the readability intent without the awkward inline cast, this change hoists the offset into a named int64_t local in both the bilinear and nearest branches:

const int64_t bottom_data_offset = (SafeInt<int64_t>(roi_batch_ind) * channels + c) * height * width;
const T* offset_bottom_data = bottom_data + bottom_data_offset;

Initializing an int64_t directly from the SafeInt<int64_t> expression is unambiguous (it selects operator int64_t()), so this compiles cleanly, keeps the SafeInt overflow checking on the offset computation, and reads more clearly than the inline cast. No behavior change.

Motivation and Context

Improves readability of the index arithmetic introduced in #29605 while keeping the overflow-checked offset computation intact.

Tests

Covered by the existing CropAndResizeTest suite — all 10 tests pass:

onnxruntime_provider_test --gtest_filter='CropAndResizeTest.*'

[Copilot]

Pull request overview

This PR is a small readability follow-up in the CPU contrib CropAndResize implementation (CropAndResizeForward). It hoists the per-channel base pointer offset computation into a named int64_t local to avoid an inline cast while preserving SafeInt<int64_t> overflow-checked arithmetic and avoiding ambiguous pointer + SafeInt overload resolution.

Changes:

• Hoist the SafeInt<int64_t>-computed base offset into a named const int64_t bottom_data_offset in the bilinear branch.
• Apply the same hoist in the nearest-neighbor branch to keep both branches consistent.