Improve node and node argument name generation - #3649
Merged
Conversation
tianleiwu
reviewed
Apr 23, 2020
Try not to modify base name (#3638)
wschin
commented
Apr 26, 2020
|
|
||
| REG_KERNEL_NONTEMPL(Clip, 12, Clip, float, double, int8_t, uint8_t, int64_t, uint64_t); | ||
|
|
||
| template<typename T> |
Contributor
Author
There was a problem hiding this comment.
If Eigen is put in clip.h, it will be included in CUDA kernel's header and trigger a NVCC bug.
ke1337
reviewed
Apr 27, 2020
|
|
||
| // Strings which have been used as node names. | ||
| // New node name should not conflict with this set. | ||
| std::unordered_set<std::string> generated_node_names_; |
Contributor
There was a problem hiding this comment.
generated_node_names_ [](start = 34, length = 21)
some models seem to have no node names. Will that still be supported?
Contributor
Author
There was a problem hiding this comment.
If the function is called to generate names form them, yes. For example, it will not generate "" if "" is a node name in the model file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the efforts in #3638 to master branch. This change has two benefits.
Q: Why we don't use a global naming manager?
A: