Skip to content

Fix profiling with C API #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snnn merged 2 commits into from
Apr 4, 2019
Merged

Fix profiling with C API #710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3280697
Fix profiling with C API
mika-fischer Mar 26, 2019
31035e0
Handle exceptions when calling EndProfiling during Session destruction
mika-fischer Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion onnxruntime/core/session/inference_session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,22 @@ InferenceSession::InferenceSession(const SessionOptions& session_options, loggin
}
}

InferenceSession::~InferenceSession() = default;
InferenceSession::~InferenceSession() {
if (session_options_.enable_profiling) {
try {
EndProfiling();
} catch (std::exception& e) {
// TODO: Currently we have no way to transport this error to the API user
// Maybe this should be refactored, so that profiling must be explicitly
// started and stopped via C-API functions.
// And not like now a session option and therefore profiling must be started
// and stopped implicitly.
LOGS(*session_logger_, ERROR) << "Error during EndProfiling(): " << e.what();
} catch (...) {
LOGS(*session_logger_, ERROR) << "Unknown error during EndProfiling()";
}
}
}

common::Status InferenceSession::RegisterExecutionProvider(std::unique_ptr<IExecutionProvider> p_exec_provider) {
if (p_exec_provider == nullptr) {
Expand Down