Move call to log and fmaxf outside of inner loop used by LogSoftmax - #745
Merged
Conversation
gramalingam
approved these changes
Apr 1, 2019
jnagi-intel
pushed a commit
to jnagi-intel/onnxruntime
that referenced
this pull request
Jan 5, 2026
This reverts commit bc3dc45.
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
…on pass (#745) ## Describe your changes Fix output path for ranked models generated by transformer optimization pass Ranked model includes the model suffix name i.e. model_XX.onnx and the pass should avoid appending it again. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value doesn't change in inner loop.