Rename misleading test names in ConvTranspose op tests - #788
Merged
Conversation
snnn
approved these changes
Apr 6, 2019
jnagi-intel
pushed a commit
to jnagi-intel/onnxruntime
that referenced
this pull request
Jan 5, 2026
* Changed fix * Fix to omit subgraph * Commit a fix for cluster index len * Fixing the Warning with size_t on clusters * Loop Test fix
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
) ## Describe your changes Pydantic v2 had significant breaking changes which blocks migration to it. So, we pinned the version to v1. Pydantic v2 has a `v1` namespace inside it. This PR introduces `olive.common.pydantic_v1` module that handles the import of `v1` api so that Olive can be version agnostic wrt pydantic. This way, we won't have version conflict with client applications such as that in microsoft/Olive#709. Note: The doc builder still needs pydantic v1 and autodoc_pydantic v1 since we are using the v1 api. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #699
Unable to add actual 3D tests for ConvTranspose as they are not yet supported by the implementation