Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Change the layout style of market item list#308

Merged
yiyione merged 7 commits intomasterfrom
layout-ui
Jun 10, 2021
Merged

Change the layout style of market item list#308
yiyione merged 7 commits intomasterfrom
layout-ui

Conversation

@debuggy
Copy link
Contributor

@debuggy debuggy commented Jun 3, 2021

Main features:

  1. Shrink the item card (including icon and info section) and also the layout of item card list view.
  2. Split 3 sections in item list view: Official, Public and Private. Each section has a more button to expand.
  3. Add categories filter in sidebar.
  4. Refine the filter logic to support multiple filter rules and query in the meantime.

Before:
image

After:
image

filter:
image

@debuggy debuggy requested a review from yiyione June 3, 2021 11:31
@debuggy debuggy requested a review from a team as a code owner June 3, 2021 11:31
@hippogr
Copy link

hippogr commented Jun 4, 2021

er, it is not your change, but I am just curious why we use Chinese character here? Only Chinese people can access this repo?


In reply to: 854270976


Refers to: webportal/src/app/assets/data.svg:5 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

@yiyione yiyione closed this Jun 4, 2021
@yiyione yiyione reopened this Jun 4, 2021
@yiyione
Copy link
Contributor

yiyione commented Jun 4, 2021

sorry for the close ……

@qfyin
Copy link
Contributor

qfyin commented Jun 4, 2021

I guess it's caused by OU Yang's authoring tool.


In reply to: 854270976


Refers to: webportal/src/app/assets/data.svg:5 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

@qfyin
Copy link
Contributor

qfyin commented Jun 4, 2021

alert(`Update item ${itemId} successed.`);

Successfully updated item XXXX.


Refers to: webportal/src/app/utils/marketplace_api.js:176 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

@qfyin
Copy link
Contributor

qfyin commented Jun 4, 2021

alert(`Delete item ${itemId} successed.`);

Successfully deleted item XXXX.


Refers to: webportal/src/app/utils/marketplace_api.js:195 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

@qfyin
Copy link
Contributor

qfyin commented Jun 4, 2021

alert(`Delete item ${itemId} successed.`);

BTW, for a succeeded action like this, I personally don't like to be interrupted by a message box.
A notifiation message like in VS Code or Azure Portal might be better.
I remember in OpenPAI portal there's similar stuff.


Refers to: webportal/src/app/utils/marketplace_api.js:195 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

@debuggy
Copy link
Contributor Author

debuggy commented Jun 4, 2021

er, it is not your change, but I am just curious why we use Chinese character here? Only Chinese people can access this repo?

Refers to: webportal/src/app/assets/data.svg:5 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

It is because this svg file is auto-generated by adobe xd, which is given from our designer

@hippogr
Copy link

hippogr commented Jun 9, 2021

you may change it in the future since this project is not for China only...


In reply to: 854321298


Refers to: webportal/src/app/assets/data.svg:5 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

hippogr
hippogr previously approved these changes Jun 9, 2021
Copy link

@hippogr hippogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@debuggy
Copy link
Contributor Author

debuggy commented Jun 9, 2021

you may change it in the future since this project is not for China only...

In reply to: 854321298

Refers to: webportal/src/app/assets/data.svg:5 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

Sure, although it will be a big project. I have discussed with designer if the output svg file could use English as default language, maybe I could double check with him.

@debuggy
Copy link
Contributor Author

debuggy commented Jun 9, 2021

alert(`Delete item ${itemId} successed.`);

BTW, for a succeeded action like this, I personally don't like to be interrupted by a message box.
A notifiation message like in VS Code or Azure Portal might be better.
I remember in OpenPAI portal there's similar stuff.

Refers to: webportal/src/app/utils/marketplace_api.js:195 in 0f6ada0. [](commit_id = 0f6ada0, deletion_comment = False)

The alert message has been updated.

Maybe we could use a univeral message bar as a notification for successful action.

Copy link

@hippogr hippogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yiyione yiyione merged commit 2599041 into master Jun 10, 2021
@yiyione yiyione deleted the layout-ui branch June 10, 2021 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants