This repository was archived by the owner on Jun 6, 2024. It is now read-only.
[display event] add event watcher in database controller #4939
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| const logger = require('@dbc/common/logger'); | ||
|
|
||
| // We doesn't allow unhandled promise rejection. | ||
| // It will make the watcher stop all actions (in some rare cases). | ||
| process.on('unhandledRejection', function(reason, p) { | ||
| logger.error( | ||
| `Encounter unhandled rejection of promise, reason: ${reason}`, | ||
| function() { | ||
| process.exit(1); | ||
| }, | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| const basicConfig = require('@dbc/common/config'); | ||
| const _ = require('lodash'); | ||
| const Joi = require('joi'); | ||
|
|
||
| const configSchema = Joi.object() | ||
| .keys({ | ||
| dbConnectionStr: Joi.string().required(), | ||
| maxDatabaseConnection: Joi.number() | ||
| .integer() | ||
| .required(), | ||
| maxRpcConcurrency: Joi.number() | ||
| .integer() | ||
| .required(), | ||
| diskPath: Joi.string().required(), | ||
| diskCheckIntervalSecond: Joi.number() | ||
| .integer() | ||
| .required(), | ||
| maxDiskUsagePercent: Joi.number() | ||
| .integer() | ||
| .required(), | ||
| }) | ||
| .required(); | ||
|
|
||
| const config = { | ||
| dbConnectionStr: process.env.DB_CONNECTION_STR, | ||
| maxDatabaseConnection: parseInt(process.env.MAX_DB_CONNECTION), | ||
| maxRpcConcurrency: parseInt(process.env.MAX_RPC_CONCURRENCY), | ||
| diskPath: process.env.DISK_PATH, | ||
| diskCheckIntervalSecond: 60, | ||
| maxDiskUsagePercent: parseInt(process.env.MAX_DISK_USAGE_PERCENT), | ||
| }; | ||
|
|
||
| const { error, value } = Joi.validate(config, configSchema); | ||
| if (error) { | ||
| throw new Error(`Config error\n${error}`); | ||
| } | ||
|
|
||
| module.exports = _.assign(basicConfig, value); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| require('module-alias/register'); | ||
| require('dotenv').config(); | ||
| const AsyncLock = require('async-lock'); | ||
| const _ = require('lodash'); | ||
| const DatabaseModel = require('openpaidbsdk'); | ||
| const { default: PQueue } = require('p-queue'); | ||
| const interval = require('interval-promise'); | ||
| require('@dbc/common/init'); | ||
| const logger = require('@dbc/common/logger'); | ||
| const { getEventInformer } = require('@dbc/common/k8s'); | ||
| const { alwaysRetryDecorator } = require('@dbc/common/util'); | ||
| const disk = require('diskusage'); | ||
| const config = require('@dbc/watcher/cluster-event/config'); | ||
|
|
||
| // Here, we use AsyncLock to control the concurrency of events with the same uid; | ||
| // e.g. If one event has ADDED, MODIFED, and MODIFED incidents, we use AsyncLock | ||
| // to ensure they will be delivered to write-merger in order. | ||
| // In the same time, we use PQueue to control the concurrency of events with different uid; | ||
| // e.g. If there are event 1 ~ event 30000, only some of them can be processed concurrently. | ||
| const lock = new AsyncLock({ maxPending: Number.MAX_SAFE_INTEGER }); | ||
| const queue = new PQueue({ concurrency: config.maxRpcConcurrency }); | ||
| const databaseModel = new DatabaseModel( | ||
| config.dbConnectionStr, | ||
| config.maxDatabaseConnection, | ||
| ); | ||
|
|
||
| async function synchronizeEvent(eventType, apiObject) { | ||
| // query db instead | ||
| const uid = apiObject.metadata.uid; | ||
| const names = apiObject.involvedObject.name.split('-'); | ||
|
|
||
| const obj = { | ||
| uid: uid, | ||
| frameworkName: names[0], | ||
| podUid: apiObject.involvedObject.uid, | ||
| taskroleName: names[1], | ||
| taskName: apiObject.involvedObject.name, | ||
| taskIndex: parseInt(names[2]), | ||
| type: apiObject.type, | ||
| reason: apiObject.reason, | ||
| message: apiObject.message, | ||
| firstTimestamp: apiObject.firstTimestamp, | ||
| lastTimestamp: apiObject.lastTimestamp, | ||
| count: apiObject.count, | ||
| sourceComponent: _.get(apiObject, 'source.component', null), | ||
| sourceHost: _.get(apiObject, 'source.host', null), | ||
| event: JSON.stringify(apiObject), | ||
| }; | ||
|
|
||
| databaseModel.FrameworkEvent.upsert(obj, { where: { uid: uid } }); | ||
yqwang-ms marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| const eventHandler = (eventType, apiObject) => { | ||
| /* | ||
| framework name-based lock + always retry | ||
| */ | ||
| const receivedTs = new Date().getTime(); | ||
| const involvedObjKind = apiObject.involvedObject.kind; | ||
| const involvedObjName = apiObject.involvedObject.name; | ||
| const uid = apiObject.metadata.uid; | ||
| if ( | ||
| involvedObjKind === 'Pod' && | ||
| /^[a-z0-9]{32}-[A-Za-z0-9._~]+-[0-9]+$/.test(involvedObjName) | ||
| ) { | ||
| logger.info( | ||
| `Cluster event type=${eventType} receivedTs=${receivedTs} uid=${uid} involvedObjKind=${involvedObjKind} involvedObjName=${involvedObjName} received.`, | ||
| ); | ||
| lock.acquire(uid, () => { | ||
| return queue.add( | ||
| alwaysRetryDecorator( | ||
| () => synchronizeEvent(eventType, apiObject), | ||
| `Sync to database type=${eventType} receivedTs=${receivedTs} uid=${uid} involvedObjKind=${involvedObjKind} involvedObjName=${involvedObjName}`, | ||
| ), | ||
| ); | ||
| }); | ||
| } else { | ||
| logger.info( | ||
| `Cluster Event type=${eventType} receivedTs=${receivedTs} uid=${uid} involvedObjKind=${involvedObjKind} involvedObjName=${involvedObjName} received but ignored.`, | ||
| ); | ||
| } | ||
| }; | ||
|
|
||
| async function assertDiskUsageHealthy() { | ||
|
Member
There was a problem hiding this comment. Better to limit the quota per job and global, and does not impact the critical path.
Contributor
Author
There was a problem hiding this comment. Recorded in #4953 . We can solve this problem in the future. |
||
| try { | ||
| const { available, total } = await disk.check(config.diskPath); | ||
| const currentUsage = ((total - available) / total) * 100; | ||
| logger.info(`Current internal storage usage is ${currentUsage}% .`); | ||
| if (currentUsage > config.maxDiskUsagePercent) { | ||
| logger.error( | ||
| `Internal storage usage exceeds ${config.maxDiskUsagePercent}%, exit.`, | ||
| function() { | ||
| process.exit(1); | ||
| }, | ||
| ); | ||
| } | ||
| } catch (err) { | ||
| logger.error(`Check disk usage fails, details: ${err}`, function() { | ||
| process.exit(1); | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| function startInformer() { | ||
| const informer = getEventInformer(); | ||
|
|
||
| informer.on('add', apiObject => { | ||
| eventHandler('ADDED', apiObject); | ||
| }); | ||
| informer.on('update', apiObject => { | ||
| eventHandler('MODIFED', apiObject); | ||
| }); | ||
| informer.on('delete', apiObject => { | ||
| eventHandler('DELETED', apiObject); | ||
| }); | ||
| informer.on('error', err => { | ||
| // If any error happens, the process should exit, and let Kubernetes restart it. | ||
| logger.error(err, function() { | ||
| process.exit(1); | ||
| }); | ||
| }); | ||
| informer.start(); | ||
| } | ||
|
|
||
| function startDiskCheck() { | ||
| interval(assertDiskUsageHealthy, config.diskCheckIntervalSecond * 1000, { | ||
| stopOnError: false, | ||
| }); | ||
| } | ||
|
|
||
| async function main() { | ||
| await assertDiskUsageHealthy(); | ||
| startInformer(); | ||
| startDiskCheck(); | ||
| } | ||
|
|
||
| main(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also limit for history ? Why not move non-critical things to another DB server?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recorded in #4954 . We can solve this problem in the future.