Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.

Rest API for retry-history#4958

Merged
suiguoxin merged 18 commits intomicrosoft:masterfrom
suiguoxin:retry-history
Oct 22, 2020
Merged

Rest API for retry-history#4958
suiguoxin merged 18 commits intomicrosoft:masterfrom
suiguoxin:retry-history

Conversation

@suiguoxin
Copy link
Contributor

@suiguoxin suiguoxin commented Oct 14, 2020

Support 2 new APIs:

  • Get job status with specific job attempt: /api/v2/jobs/{user}~{job}/attempts/{jobAttemptId}
  • Get task status: /api/v2/jobs/{user}~{job}/attempts/{jobAattemptId}/taskRoles/{taskRoleName}/taskIndex/{taskIndex}/attempts

@coveralls
Copy link

coveralls commented Oct 14, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 34.037% when pulling aa3e071 on suiguoxin:retry-history into 869e14f on microsoft:master.

yqwang-ms
yqwang-ms reviewed Oct 14, 2020
View reviewed changes
abuccts
abuccts reviewed Oct 14, 2020
View reviewed changes
src/rest-server/src/utils/frameworkConverter.js
@@ -1,46 +1,38 @@
// Copyright (c) Microsoft Corporation
Copy link
Member

@abuccts abuccts Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you put this file under src/models/v2/job/? it's not a common utility and is only used by v2/job related

Copy link
Contributor Author

@suiguoxin suiguoxin Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you put this file under src/models/v2/job/? it's not a common utility and is only used by v2/job related

Moved to src/models/v2/utils. The utility is also used by v2/job-attempt and v2/task.

src/rest-server/src/utils/name.js
@@ -0,0 +1,57 @@
// Copyright (c) Microsoft Corporation
Copy link
Member

@abuccts abuccts Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

@suiguoxin suiguoxin Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Fixed

@suiguoxin suiguoxin mentioned this pull request Oct 14, 2020
Merged
yqwang-ms
yqwang-ms reviewed Oct 14, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 14, 2020
View reviewed changes
@suiguoxin suiguoxin closed this Oct 15, 2020
@suiguoxin suiguoxin reopened this Oct 15, 2020
abuccts
abuccts reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix the failed api tests in Jenkins

yqwang-ms
yqwang-ms reviewed Oct 16, 2020
View reviewed changes
@yqwang-ms
Copy link
Member

yqwang-ms commented Oct 16, 2020 •
edited
Loading

Job attempt changed, but response is the same:
https://int.org/rest-server/api/v2/jobs/yqwang~taskhistory-elastic-2/attempts/1/
https://int.org/rest-server/api/v2/jobs/yqwang~taskhistory-elastic-2/attempts/0/ #Closed

@yqwang-ms
Copy link
Member

yqwang-ms commented Oct 20, 2020 

  ).getTime() || null,

currentAttemptCreatedTime = taskStatus.attemptStatus.startTime

In reply to: 711682627 [](ancestors = 711682627)

Refers to: src/rest-server/src/models/v2/job/k8s.js:133 in 33b39f8. [](commit_id = 33b39f8, deletion_comment = False)

yqwang-ms
yqwang-ms reviewed Oct 20, 2020
View reviewed changes
@suiguoxin suiguoxin force-pushed the retry-history branch 2 times, most recently from b9bfc07 to 8946f20 Compare October 20, 2020 14:48
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

yqwang-ms
yqwang-ms suggested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
yqwang-ms
yqwang-ms approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@suiguoxin suiguoxin merged commit b8c57ad into microsoft:master Oct 22, 2020
@suiguoxin suiguoxin deleted the retry-history branch October 22, 2020 03:27
@suiguoxin suiguoxin mentioned this pull request Oct 29, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hzy46 hzy46 Awaiting requested review from hzy46

@debuggy debuggy Awaiting requested review from debuggy

@Binyang2014 Binyang2014 Awaiting requested review from Binyang2014

@abuccts abuccts Awaiting requested review from abuccts

1 more reviewer

@yqwang-ms yqwang-ms yqwang-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suiguoxin @coveralls @yqwang-ms @Binyang2014 @abuccts