Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.

Add task retry info in job detail page#4966

Merged
debuggy merged 45 commits intomasterfrom
mintao/task_retry
Oct 22, 2020
Merged

Add task retry info in job detail page#4966
debuggy merged 45 commits intomasterfrom
mintao/task_retry

Conversation

@debuggy
Copy link
Contributor

@debuggy debuggy commented Oct 14, 2020

  1. Add a new page to show task attempts of a single task ({jobAttempt}/{taskrole}/{taskIndex})

image

  1. Reorg the job detail page UI. Mainly in taskrole sections

image

@coveralls
Copy link

coveralls commented Oct 14, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 34.276% when pulling 2d2a7ff on mintao/task_retry into 12c3a9b on master.

@debuggy debuggy mentioned this pull request Oct 15, 2020
Closed
31 tasks
yqwang-ms
yqwang-ms reviewed Oct 16, 2020
View reviewed changes
@yqwang-ms
Copy link
Member

yqwang-ms commented Oct 16, 2020 •
edited
Loading

After job submission, the waiting job detail page is empty (without any info, such as loading) #Closed

yqwang-ms
yqwang-ms reviewed Oct 16, 2020
View reviewed changes
@yqwang-ms
Copy link
Member

yqwang-ms commented Oct 16, 2020 •
edited
Loading

Perf test for a job with 2k tasks, 10 job attempts and each task 10 task attempts? #Closed

yqwang-ms
yqwang-ms reviewed Oct 16, 2020
View reviewed changes
@debuggy
Copy link
Contributor Author

debuggy commented Oct 16, 2020 •
edited by yqwang-ms
Loading

After job submission, the waiting job detail page is empty (without any info, such as loading)

fixed #Closed

@yqwang-ms
Copy link
Member

yqwang-ms commented Oct 20, 2020 •
edited
Loading

Add time?
See RestServer Time Mapping in 1note

#Closed

@debuggy
Copy link
Contributor Author

debuggy commented Oct 20, 2020

Add time?
See RestServer Time Mapping in 1note

done

yqwang-ms
yqwang-ms reviewed Oct 20, 2020
View reviewed changes
src/webportal/src/app/job/job-view/fabric/task-attempt/task-attempt-list.jsx
},
];
const columns = defaultColumns;
return columns;
Copy link
Member

@yqwang-ms yqwang-ms Oct 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

columns [](start = 11, length = 7)

order the cols the same as job detail page? #Closed

Copy link
Contributor Author

@debuggy debuggy Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

yqwang-ms
yqwang-ms reviewed Oct 20, 2020
View reviewed changes
yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
src/webportal/src/app/job/job-view/fabric/task-attempt.jsx
</Stack>
<Stack gap='m'>
<Text>Task Duration</Text>
<Text>
Copy link
Member

@yqwang-ms yqwang-ms Oct 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to job detail page, add Task Running Start Time and Task Running Duration? #Closed

Copy link
Contributor Author

@debuggy debuggy Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@yqwang-ms yqwang-ms Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Add, and keep existing such as Task Duration, Task Created Time?

In reply to: 508961967 [](ancestors = 508961967)

Copy link
Contributor Author

@debuggy debuggy Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
src/webportal/src/app/job/job-view/fabric/task-attempt.jsx
<Text>Task Running Duration</Text>
<Text>
{getDurationString(
getTimeDuration(
Copy link
Member

@yqwang-ms yqwang-ms Oct 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename all Created Time to be Creation Time? Align to submission time? #Closed

Copy link
Contributor Author

@debuggy debuggy Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

yqwang-ms
yqwang-ms approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yqwang-ms
Copy link
Member

yqwang-ms commented Oct 21, 2020 

          </Link>

View Exit Diagnostics is from appExitDiagnostics/appExitSpec, so it is app (i.e. job attempt level) info, so it should be moved to Job Attempt Section (i.e. under Job Attempt Index)

Refers to: src/webportal/src/app/job/job-view/fabric/job-detail/components/summary.jsx:510 in 2d2a7ff. [](commit_id = 2d2a7ff, deletion_comment = False)

yqwang-ms
yqwang-ms reviewed Oct 21, 2020
View reviewed changes
src/webportal/src/app/job/job-view/fabric/job-detail.jsx
onText='More Diagnostics'
offText='More Diagnostics'
onChange={this.onChangeShowMoreDiagnostics}
/>
Copy link
Member

@yqwang-ms yqwang-ms Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when switch job attempt, table content and this button is unmatched

yqwang-ms
yqwang-ms suggested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

yqwang-ms
yqwang-ms approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@debuggy debuggy merged commit 0d25e8b into master Oct 22, 2020
@debuggy debuggy deleted the mintao/task_retry branch November 26, 2020 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hzy46 hzy46 Awaiting requested review from hzy46

@suiguoxin suiguoxin Awaiting requested review from suiguoxin

@yiyione yiyione Awaiting requested review from yiyione

1 more reviewer

@yqwang-ms yqwang-ms yqwang-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@debuggy @coveralls @yqwang-ms @Binyang2014