Add ssh public keys on user-profile page by Lijiaoa · Pull Request #5223 · microsoft/pai

Lijiaoa · 2021-01-05T08:51:40Z

TODO:

check input format together

improve SSH layout:

coveralls · 2021-01-05T08:54:59Z

Coverage remained the same at 33.896% when pulling 35ce9f5 on Lijiaoa:dev-ssh into 65df0d7 on microsoft:master.

hzy46 · 2021-02-03T06:09:11Z

src/webportal/src/app/user/fabric/user-profile/ssh-list.jsx

@@ -0,0 +1,159 @@
+// Copyright (c) Microsoft Corporation


Please use this header:

// Copyright (c) Microsoft Corporation. // Licensed under the MIT License.

Will modifiy it. And looks like that still have many files write that.

Yes, they are the old headers. We haven't modified them. This one is the new header.

hzy46 · 2021-02-03T06:23:47Z

src/webportal/src/app/job-submission/components/tools/job-ssh.jsx

+          </Hint>
+          <Stack horizontal gap='l1'>
+            <TextField
+              Lable='Add additional ssh public key'


Please change ssh to SSH.

hzy46 · 2021-02-03T06:23:52Z

src/webportal/src/app/job-submission/components/tools/job-ssh.jsx

+          <Stack horizontal gap='l1'>
+            <TextField
+              Lable='Add additional ssh public key'
+              placeholder='Additional ssh public key'


Please change ssh to SSH.

hzy46 · 2021-02-03T06:25:32Z

src/webportal/src/app/user/fabric/user-profile.jsx

          >
            <TokenList tokens={tokens} onRevoke={onRevokeToken} />
          </UserProfileCard>
+          <UserProfileCard


Please move this UserProfileCard of SSH Public Keys before the UserProfileCard of Tokens.

SSH is supposed to be used more frequently than tokens.

hzy46 · 2021-02-03T06:27:43Z

src/webportal/src/app/user/fabric/user-profile/ssh-list.jsx

+        }}
+        minWidth={400}
+      >
+        <div>Are you sure you want to delete this ssh key?</div>


Please change ssh to SSH.

hzy46 · 2021-02-03T06:29:09Z

src/webportal/src/app/user/fabric/user-profile/ssh-list-dialog.jsx

+    if (title.trim() === '') {
+      setInputTitleError('Please input title');
+    } else if (value.trim() === '') {
+      setInputValueError('Please input ssk value');


Please change ssk to SSH.

hzy46 · 2021-02-03T06:51:18Z

src/webportal/src/app/user/fabric/user-profile/ssh-list-dialog.jsx

+      setInputTitleError('Please input title');
+    } else if (value.trim() === '') {
+      setInputValueError('Please input ssk value');
+    } else {


Please validate the value matches SSH key's format.

You can use this regex: /^ssh-rsa AAAA[0-9A-Za-z+/]+[=]{0,3}.*$/

hzy46 · 2021-02-03T06:52:59Z

src/webportal/src/app/user/fabric/user-profile.jsx

+  // click `add public ssh keys button` -> open dialog
+  const onAddPublicKeys = useCallback(async sshPublicKeys => {
+    setSSHProcessing(true);
+    let updatedSSHPublickeys = [];


Please validate here: the user cannot add ssh keys with duplicate titles. (Title should be unique for one user)

hzy46 · 2021-02-03T06:55:06Z

src/webportal/src/app/user/fabric/user-profile.jsx

+    }
+    updatedSSHPublickeys = updatedSSHPublickeys.filter(
+      item =>
+        item.title !== sshPublicKeys.title &&


Please only filter with item.title !== sshPublicKeys.title.

Title should be unique and delete means delete an ssh key with a certain title.

hzy46 · 2021-02-03T06:56:05Z

src/webportal/src/app/user/fabric/user-profile/ssh-list-dialog.jsx

+        <div>
+          <div className={t.mt1}>
+            <TextField
+              label='title'


Better to give the user some hints.

title -> Title (Please give the SSH key a name):

hzy46 · 2021-02-03T06:57:03Z

src/webportal/src/app/user/fabric/user-profile/ssh-list-dialog.jsx

+          </div>
+          <div className={t.mt1}>
+            <TextField
+              label='value'


Better to give the user some hints.

value -> Value (SSH Public key, starts with ssh-rsa):

hzy46 · 2021-02-03T07:01:03Z

src/webportal/src/app/user/fabric/conn.js

+      data: {
+        username: username,
+        extension: {
+          sshKeys: sskMessage,


sskMessage -> sshMessage?

hzy46 · 2021-02-03T07:01:18Z

src/webportal/src/app/user/fabric/conn.js

  });
 };

+export const updateUserRequest = async (username, sskMessage) => {


sskMessage -> sshMessage?

hzy46 · 2021-02-04T02:36:01Z

src/webportal/src/app/user/fabric/user-profile/ssh-list-dialog.jsx

+      }
+    }
+
+    // if (title.trim() === '') {


Please remove these comments

add ssh public keys

fc8db98

hzy46 mentioned this pull request Jan 18, 2021

2021 Feb Release Plan #5253

Closed

55 tasks

This was referenced Jan 25, 2021

Add a copy button to copy the SSH shell command #5261

Open

save SSH public keys on user profile page #5274

Closed

Lijiao added 2 commits February 3, 2021 04:31

improve ssh layout

c64fb10

rename sshValue to value

963853e

hzy46 reviewed Feb 3, 2021

View reviewed changes

fix comments

c521801

hzy46 reviewed Feb 3, 2021

View reviewed changes

Lijiao added 3 commits February 3, 2021 08:00

set title is unique key

29f3a22

update

aa22d17

Merge branch 'master' of https://github.com/Microsoft/pai into dev-ssh

84b9ff2

Lijiaoa closed this Feb 4, 2021

Lijiaoa reopened this Feb 4, 2021

hzy46 reviewed Feb 4, 2021

View reviewed changes

del notes

35ce9f5

hzy46 approved these changes Feb 4, 2021

View reviewed changes

hzy46 merged commit 7008caa into microsoft:master Feb 4, 2021

siaimes mentioned this pull request Mar 27, 2021

Keep the public key used by the user last time, and automatically fill in the form when the SSH button is enabled next time #5107

Closed

Conversation

Lijiaoa commented Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hzy46 Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hzy46 Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hzy46 Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hzy46 Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Lijiaoa commented Jan 5, 2021 •

edited

Loading

coveralls commented Jan 5, 2021 •

edited

Loading

hzy46 Feb 3, 2021 •

edited

Loading

hzy46 Feb 3, 2021 •

edited

Loading

hzy46 Feb 3, 2021 •

edited

Loading

hzy46 Feb 3, 2021 •

edited

Loading