This repository was archived by the owner on Jun 6, 2024. It is now read-only.
Add ".log" suffix for user-stdout/user-stderr/user-all log files#5272
Merged
Binyang2014 merged 3 commits intomasterfrom Feb 5, 2021
Merged
Add ".log" suffix for user-stdout/user-stderr/user-all log files#5272Binyang2014 merged 3 commits intomasterfrom
Binyang2014 merged 3 commits intomasterfrom
Conversation
Member
|
Why not directly add |
Contributor
Author
Because it's easier to implement and do not need to care about how log is stored. If we change url, we need to extract the real log folder before try to get the content. Using this way to avoid string manipulate |
Gerhut
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ".log" suffix for user-stdout/user-stderr/user-all log files
Fix: #5243